| Summary: | REGRESSION(r266681) [GTK] constexpr build failure in LTS/Debian with GCC 8 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||||
| Component: | WebCore Misc. | Assignee: | Lauro Moura <lmoura> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, bugs-noreply, darin, sam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=216219 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 408256 [details]
Patch
Comment on attachment 408256 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408256&action=review > Source/WebCore/platform/text/TextCodecSingleByte.cpp:248 > + default: > + RELEASE_ASSERT_NOT_REACHED(); I guess we can do this. But sadly this has a side effect of suppressing the compile-time warning if we forget to include one of the enumeration values here. Would be nice to find a solution that does not do that. Comment on attachment 408256 [details]
Patch
I'd prefer to just remove the constexpr from this function.
Comment on attachment 408256 [details]
Patch
I'd prefer to just remove the constexpr from this function.
Don’t we need the constexpr to make this work as a template argument? Comment on attachment 408256 [details]
Patch
No, tableForDecoding isn't used as a template argument.
Created attachment 408259 [details]
Patch
Created attachment 408260 [details]
Patch
Lauro, does this fix your build? (In reply to Alex Christensen from comment #9) > Lauro, does this fix your build? Could not test it direcly on the bot but indeed it should fix. |
Error: [257/502] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-54.cpp.o FAILED: Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-54.cpp.o <snip long include line> In file included from DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:32:0, from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:56, from ../../Source/WebCore/platform/text/TextCodecCJK.cpp:26, from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-54.cpp:1: ../../Source/WebCore/platform/text/TextCodecSingleByte.cpp: In function ‘constexpr const SingleByteDecodeTable& WebCore::tableForDecoding(WebCore::TextCodecSingleByte::Encoding)’: DerivedSources/ForwardingHeaders/wtf/Assertions.h:587:56: error: call to non-constexpr function ‘void CRASH_WITH_INFO(...)’ #define RELEASE_ASSERT_NOT_REACHED(...) CRASH_WITH_INFO(__VA_ARGS__) ~~~~~~~~~~~~~~~^~~~~~~~~~~~~ ../../Source/WebCore/platform/text/TextCodecSingleByte.cpp:237:5: note: in expansion of macro ‘RELEASE_ASSERT_NOT_REACHED’ RELEASE_ASSERT_NOT_REACHED(); ^~~~~~~~~~~~~~~~~~~~~~~~~~ GCC 8 has some limitations checking non-constexpr expressions after return statements. Example: https://godbolt.org/z/dhPvaf Related GCC bugs: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86678 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67371