Bug 216272

Summary: [macOS] Date/time inputs should preserve focus on value change
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Mac   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 216188    
Attachments:
Description Flags
Patch
wenson_hsieh: review+
Patch for landing none

Aditya Keerthi
Reported 2020-09-08 08:20:06 PDT
...
Attachments
Patch (6.73 KB, patch)
2020-09-08 08:51 PDT, Aditya Keerthi 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Patch for landing (6.67 KB, patch)
2020-09-08 09:03 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2020-09-08 08:51:40 PDT
Created attachment 408229 [details] Patch
Wenson Hsieh
Comment 2 2020-09-08 08:55:14 PDT
Comment on attachment 408229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408229&action=review r=mews! > LayoutTests/fast/forms/date/date-preserve-focus-value-change.html:4 > +<script src="../../../resources/js-test-pre.js"></script> Nit - I think in new tests, we prefer to use "js-test.js” instead of -pre/-post.
Aditya Keerthi
Comment 3 2020-09-08 09:03:20 PDT
Created attachment 408230 [details] Patch for landing
Aditya Keerthi
Comment 4 2020-09-08 09:04:22 PDT
(In reply to Wenson Hsieh from comment #2) > Comment on attachment 408229 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408229&action=review > > r=mews! > > > LayoutTests/fast/forms/date/date-preserve-focus-value-change.html:4 > > +<script src="../../../resources/js-test-pre.js"></script> > > Nit - I think in new tests, we prefer to use "js-test.js” instead of > -pre/-post. Thanks for the review! Updated to use "js-test.js".
EWS
Comment 5 2020-09-08 12:22:54 PDT
Committed r266739: <https://trac.webkit.org/changeset/266739> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408230 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-08 12:23:18 PDT
<rdar://problem/68523398>
Note You need to log in before you can comment on or make changes to this bug.