Summary: | Add an experimental feature flag for CSS individual transform properties | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||||||||||||||||||||
Component: | New Bugs | Assignee: | Antoine Quint <graouts> | ||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
Severity: | Normal | CC: | changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, joepeck, koivisto, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer, youennf | ||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||||||||||
Bug Blocks: | 178117 | ||||||||||||||||||||||||||||
Attachments: |
|
Description
Antoine Quint
2020-09-08 03:53:51 PDT
Created attachment 408222 [details]
Patch
Comment on attachment 408222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408222&action=review > Source/WebKit/Shared/WebPreferences.yaml:2167 > + webcoreBinding: RuntimeEnabledFeatures Can it be made a Settings instead of RuntimeEnabledFeatures? Is it something that can be queried from background threads? Created attachment 408231 [details]
Patch
Created attachment 409669 [details]
Patch
(In reply to youenn fablet from comment #2) > Comment on attachment 408222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408222&action=review > > > Source/WebKit/Shared/WebPreferences.yaml:2167 > > + webcoreBinding: RuntimeEnabledFeatures > > Can it be made a Settings instead of RuntimeEnabledFeatures? Is it something > that can be queried from background threads? The newer patch has the flag backed by a setting. Comment on attachment 409669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409669&action=review > Source/WebCore/page/Settings.yaml:1125 > +cssIndividualTransformPropertiesEnabled: > + initial: false Why not make this a runtime flag? (In reply to Dean Jackson from comment #7) > Comment on attachment 409669 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409669&action=review > > > Source/WebCore/page/Settings.yaml:1125 > > +cssIndividualTransformPropertiesEnabled: > > + initial: false > > Why not make this a runtime flag? Did you mean a runtime-enabled feature? I think we want to do this only for process-wide flags, and this feature does not require one. See Youenn's comments above. Created attachment 409689 [details]
Patch
Created attachment 409696 [details]
Patch
Created attachment 409700 [details]
Patch
Created attachment 409701 [details]
Patch
Created attachment 409712 [details]
Patch
Created attachment 409714 [details]
Patch
Created attachment 409718 [details]
Patch
Created attachment 409731 [details]
Patch for landing
Created attachment 409732 [details]
Patch for landing
Committed r267592: <https://trac.webkit.org/changeset/267592> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409732 [details]. |