Bug 216271

Summary: Add an experimental feature flag for CSS individual transform properties
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, joepeck, koivisto, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 178117    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
none
Patch for landing none

Antoine Quint
Reported 2020-09-08 03:53:51 PDT
Add an experimental feature flag for CSS individual transform properties
Attachments
Patch (14.65 KB, patch)
2020-09-08 04:04 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (29.20 KB, patch)
2020-09-08 09:07 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (14.26 KB, patch)
2020-09-25 01:51 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (14.28 KB, patch)
2020-09-25 07:14 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.21 KB, patch)
2020-09-25 08:29 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.30 KB, patch)
2020-09-25 09:49 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (14.21 KB, patch)
2020-09-25 10:01 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.30 KB, patch)
2020-09-25 11:21 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (14.14 KB, patch)
2020-09-25 11:40 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.66 KB, patch)
2020-09-25 12:13 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.77 KB, patch)
2020-09-25 13:33 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.70 KB, patch)
2020-09-25 13:36 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2020-09-08 04:04:29 PDT
Created attachment 408222 [details] Patch
youenn fablet
Comment 2 2020-09-08 04:49:09 PDT
Comment on attachment 408222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408222&action=review > Source/WebKit/Shared/WebPreferences.yaml:2167 > + webcoreBinding: RuntimeEnabledFeatures Can it be made a Settings instead of RuntimeEnabledFeatures? Is it something that can be queried from background threads?
Antoine Quint
Comment 3 2020-09-08 09:07:26 PDT
Created attachment 408231 [details] Patch
Radar WebKit Bug Importer
Comment 4 2020-09-15 03:54:16 PDT
<rdar://problem/68914539>
Antoine Quint
Comment 5 2020-09-25 01:51:39 PDT
Created attachment 409669 [details] Patch
Antoine Quint
Comment 6 2020-09-25 01:52:22 PDT
(In reply to youenn fablet from comment #2) > Comment on attachment 408222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408222&action=review > > > Source/WebKit/Shared/WebPreferences.yaml:2167 > > + webcoreBinding: RuntimeEnabledFeatures > > Can it be made a Settings instead of RuntimeEnabledFeatures? Is it something > that can be queried from background threads? The newer patch has the flag backed by a setting.
Dean Jackson
Comment 7 2020-09-25 02:09:16 PDT
Comment on attachment 409669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409669&action=review > Source/WebCore/page/Settings.yaml:1125 > +cssIndividualTransformPropertiesEnabled: > + initial: false Why not make this a runtime flag?
Antoine Quint
Comment 8 2020-09-25 02:28:27 PDT
(In reply to Dean Jackson from comment #7) > Comment on attachment 409669 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409669&action=review > > > Source/WebCore/page/Settings.yaml:1125 > > +cssIndividualTransformPropertiesEnabled: > > + initial: false > > Why not make this a runtime flag? Did you mean a runtime-enabled feature? I think we want to do this only for process-wide flags, and this feature does not require one. See Youenn's comments above.
Antoine Quint
Comment 9 2020-09-25 07:14:06 PDT
Created attachment 409689 [details] Patch
Antoine Quint
Comment 10 2020-09-25 08:29:20 PDT
Created attachment 409696 [details] Patch
Antoine Quint
Comment 11 2020-09-25 09:49:02 PDT
Created attachment 409700 [details] Patch
Antoine Quint
Comment 12 2020-09-25 10:01:25 PDT
Created attachment 409701 [details] Patch
Antoine Quint
Comment 13 2020-09-25 11:21:49 PDT
Created attachment 409712 [details] Patch
Antoine Quint
Comment 14 2020-09-25 11:40:12 PDT
Created attachment 409714 [details] Patch
Antoine Quint
Comment 15 2020-09-25 12:13:55 PDT
Created attachment 409718 [details] Patch
Antoine Quint
Comment 16 2020-09-25 13:33:46 PDT
Created attachment 409731 [details] Patch for landing
Antoine Quint
Comment 17 2020-09-25 13:36:29 PDT
Created attachment 409732 [details] Patch for landing
EWS
Comment 18 2020-09-25 14:26:33 PDT
Committed r267592: <https://trac.webkit.org/changeset/267592> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409732 [details].
Note You need to log in before you can comment on or make changes to this bug.