Bug 216246

Summary: [WebIDL] Fix issues found by preprocess-idls.pl parser validation and enabled parser validation by default for the tests
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, glenn, jbedard, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2020-09-07 11:24:58 PDT
[WebIDL] Fix issues found by preprocess-idls.pl parser validation and enabled parser validation by default for the tests
Attachments
Patch (179.32 KB, patch)
2020-09-07 11:47 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-09-07 11:47:23 PDT
Created attachment 408190 [details] Patch
Darin Adler
Comment 2 2020-09-07 11:53:11 PDT
Comment on attachment 408190 [details] Patch Any effect on compiling the actual WebCore IDL?
Sam Weinig
Comment 3 2020-09-07 12:22:41 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 408190 [details] > Patch > > Any effect on compiling the actual WebCore IDL? Nope. I fixed those issues when I introduced the validation but neglected to fix the tests.
EWS
Comment 4 2020-09-07 12:36:57 PDT
Committed r266709: <https://trac.webkit.org/changeset/266709> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408190 [details].
Radar WebKit Bug Importer
Comment 5 2020-09-07 12:37:13 PDT
<rdar://problem/68472234>
Note You need to log in before you can comment on or make changes to this bug.