Bug 216216 – XML documents in iframes should not inherit encoding from parent frame

• Component: New Bugs
• Status: RESOLVED FIXED

[Alex Christensen]

XML documents in iframes should not inherit encoding from parent frame

[Alex Christensen]

Created attachment 408093 [details]
Patch

[Darin Adler]

Comment on attachment 408093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408093&action=review

> Source/WebCore/loader/DocumentWriter.cpp:61
> +    if (auto* document = frame ? frame->document() : nullptr) {
> +        if (document->isXMLDocument())
> +            return false;
> +    }

The code in this function dereferences frame without checking for null. And the only caller already dereferences the frame before calling this function. So we do not need to check for null here. We should change the argument type to a reference.

Also, the only caller calls this function twice in a row. It should use a boolean local instead.

Could write this:

    if (is<XMLDocument>(frame->document()))
        return false;

The null check is built into the is<> function. But also, the code below uses frame->document() without checking it for null either.

[Darin Adler]

Comment on attachment 408093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408093&action=review

> Source/WebCore/loader/DocumentWriter.cpp:59
> +        if (document->isXMLDocument())

Maybe this should be done the other way around, where the HTMLDocument case is the special one:

    if (!is<HTMLDocument>(frame->document()))
        return false;

Or:

    return is<HTMLDocument>(frame->document())
        && parentFrame && ...

[Alex Christensen]

http://trac.webkit.org/r266671

[Radar WebKit Bug Importer]

<rdar://problem/68404034>