Bug 216211

Summary: Remove all non-web-exposed uses of ENABLE(VARIATION_FONTS)
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, darin, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jonlee, kondapallykalyan, macpherson, menard, mmaxfield, pdr, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 176215    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2020-09-05 00:50:57 PDT
Because it's enabled on all Cocoa ports, and we have shipped it for years and don't plan on disabling it, we can just stop consulting with the ENABLE() in Cocoa-specific files. Also, we can start the process of enabling it for all ports by at least compiling in the internal data structures for it on all ports (but not have any web-exposed behavior change).
Attachments
Patch (25.59 KB, patch)
2020-09-05 00:51 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (29.48 KB, patch)
2020-09-06 15:24 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2020-09-05 00:51:28 PDT
Created attachment 408070 [details] Patch
Myles C. Maxfield
Comment 2 2020-09-06 15:24:10 PDT
Created attachment 408140 [details] Patch
EWS
Comment 3 2020-09-06 17:00:58 PDT
Committed r266686: <https://trac.webkit.org/changeset/266686> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408140 [details].
Radar WebKit Bug Importer
Comment 4 2020-09-06 17:01:17 PDT
<rdar://problem/68437601>
Note You need to log in before you can comment on or make changes to this bug.