Summary: | Unified build fix for "redefinition of 'kCMVideoCodecType_VP9" | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | clord, darin, eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, webkit-bug-importer, youennf, ysuzuki | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 202798 | ||||||||||||||
Attachments: |
|
Description
Jer Noble
2020-09-04 17:12:58 PDT
Created attachment 408049 [details]
Patch
Comment on attachment 408049 [details]
Patch
Build failures so I won’t r+ yet.
Created attachment 408233 [details]
Patch
Created attachment 408234 [details]
Patch
Created attachment 408235 [details]
Patch
Created attachment 408282 [details]
Patch
Comment on attachment 408282 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408282&action=review > Source/WebCore/ChangeLog:17 > + (): Deleted. Something is missing here? (In reply to Peng Liu from comment #7) > Comment on attachment 408282 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408282&action=review > > > Source/WebCore/ChangeLog:17 > > + (): Deleted. > > Something is missing here? Seems like a bug in the ChangeLog generation script. (In reply to Jer Noble from comment #8) > (In reply to Peng Liu from comment #7) > > > Source/WebCore/ChangeLog:17 > > > + (): Deleted. > > > > Something is missing here? > > Seems like a bug in the ChangeLog generation script. Yes, definitely is. The script has a lot of bugs so I recommend looking over what it generated. It’s there to help you write the change log, not to write it for you. However, since a lot of people are not writing per-function change log I’m starting to wonder what we should do. Not sure that blob of text is doing a lot of good if the person who wrote the change log isn’t reading it. Comment on attachment 408282 [details]
Patch
ENABLE_VP9 is Mac Big Sur only, RTC_ENABLE_VP9 is on in all cases.
Maybe we should rationalise that.
Committed r267185: <https://trac.webkit.org/changeset/267185> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408282 [details]. |