Bug 216173

Summary: Binding generator is not always computing the right interface attributes
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, esprehn+autocc, ews-watchlist, glenn, jbedard, kangil.han, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2020-09-04 03:40:08 PDT
Binding generator is not always computing the right interface attributes
Attachments
Patch (223.32 KB, patch)
2020-09-04 03:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (223.53 KB, patch)
2020-09-04 05:55 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-09-04 03:45:38 PDT
Created attachment 407954 [details] Patch
youenn fablet
Comment 2 2020-09-04 05:55:31 PDT
Created attachment 407963 [details] Patch
Alex Christensen
Comment 3 2020-09-04 08:29:29 PDT
Comment on attachment 407963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407963&action=review > Source/WebCore/dom/TextEncoder.idl:-27 > - Exposed=(Window,Worker), I also added "dictionary" to Exposed in IDLAttributes.json which should probably be removed with this.
youenn fablet
Comment 4 2020-09-04 09:24:34 PDT
(In reply to Alex Christensen from comment #3) > Comment on attachment 407963 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407963&action=review > > > Source/WebCore/dom/TextEncoder.idl:-27 > > - Exposed=(Window,Worker), > > I also added "dictionary" to Exposed in IDLAttributes.json which should > probably be removed with this. OK, will fix it in a follow-up
EWS
Comment 5 2020-09-04 09:40:15 PDT
Committed r266615: <https://trac.webkit.org/changeset/266615> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407963 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-04 09:42:29 PDT
<rdar://problem/68350821>
Sam Weinig
Comment 7 2020-09-04 10:24:12 PDT
Comment on attachment 407963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407963&action=review >>> Source/WebCore/dom/TextEncoder.idl:-27 >>> - Exposed=(Window,Worker), >> >> I also added "dictionary" to Exposed in IDLAttributes.json which should probably be removed with this. > > OK, will fix it in a follow-up Exposed is not valid on a dictionary, see https://heycam.github.io/webidl/#Exposed for the complete list of valid contexts.
Note You need to log in before you can comment on or make changes to this bug.