Summary: | [CG] Cache the last status of the image encoded data | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
Component: | Images | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | peng.liu6, simon.fraser, thorton, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Said Abou-Hallawa
2020-09-02 15:48:54 PDT
Created attachment 407830 [details]
Patch
Comment on attachment 407830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407830&action=review > Source/WebCore/ChangeLog:9 > + can be made with calling system functions. s/with/without/ Sounds like? Created attachment 407838 [details]
Patch
Comment on attachment 407838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407838&action=review > Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:-239 > - // Ragnaros yells: TOO SOON! You have awakened me TOO SOON, Executus! This critical historical documentation must remain! Created attachment 408470 [details]
Patch
Comment on attachment 407838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407838&action=review >> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:-239 >> - // Ragnaros yells: TOO SOON! You have awakened me TOO SOON, Executus! > > This critical historical documentation must remain! I put it back :) Comment on attachment 408470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408470&action=review > Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:253 > + m_encodedDataStatus = EncodedDataStatus::Error; Could be a one liner: m_encodedDataStatus = !m_isAllDataReceived ? EncodedDataStatus::Unknown : EncodedDataStatus::Error; > Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:260 > RetainPtr<CFDictionaryRef> image0Properties = adoptCF(CGImageSourceCopyPropertiesAtIndex(m_nativeDecoder.get(), 0, imageSourceOptions().get())); auto > Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:266 > + if (!CFDictionaryContainsKey(image0Properties.get(), kCGImagePropertyPixelWidth) || !CFDictionaryContainsKey(image0Properties.get(), kCGImagePropertyPixelHeight)) { You could group both this if and previous if in a single statement. Created attachment 408694 [details]
Patch
Committed r267016: <https://trac.webkit.org/changeset/267016> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408694 [details]. |