Bug 21610

Summary: run-webkit-threads --threaded crashes in StructureID destructor
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: JavaScriptCoreAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
proposed fix darin: review+

Alexey Proskuryakov
Reported 2008-10-15 05:36:22 PDT
There is a debug-only HashSet in StructureID.cpp that is not protected with locks. This makes run-webkit-tests crash quickly.
Attachments
proposed fix (1.99 KB, patch)
2008-10-15 05:58 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2008-10-15 05:58:32 PDT
Created attachment 24359 [details] proposed fix
Darin Adler
Comment 2 2008-10-15 09:11:40 PDT
Comment on attachment 24359 [details] proposed fix #include <wtf/RefPtr.h> +#if ENABLE(JSC_MULTIPLE_THREADS) +#include <wtf/Threading.h> +#endif #ifdef'd includes normally go in a separate paragraph. Since this is debug-only code it would be nice if there was some no-op version of Mutex and MutexLocker for the single-thread case to keep the #if to a minimum -- performance is not a critical concern. r=me
Alexey Proskuryakov
Comment 3 2008-10-15 23:41:36 PDT
Committed revision 37630.
Note You need to log in before you can comment on or make changes to this bug.