Bug 216098

Summary: Use unicode macros instead of manual range checks in TextCodecUTF16
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2020-09-02 14:18:19 PDT
Use unicode macros instead of manual range checks in TextCodecUTF16
Attachments
Patch (21.31 KB, patch)
2020-09-02 14:19 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.67 KB, patch)
2020-09-02 14:23 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.49 KB, patch)
2020-09-02 22:30 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-09-02 14:19:05 PDT
Created attachment 407813 [details] Patch
Darin Adler
Comment 2 2020-09-02 14:22:16 PDT
Comment on attachment 407813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407813&action=review > Source/WebCore/platform/text/TextCodecSingleByte.cpp:2 > + * Copyright (C) 2020 Apple Inc. All rights reserved. I assume you didn’t mean to include this in this patch. > Source/WebCore/platform/text/TextCodecSingleByte.h:32 > +class TextCodecSingleByte : public TextCodec { I assume you didn’t mean to include this in this patch.
Alex Christensen
Comment 3 2020-09-02 14:22:42 PDT
Comment on attachment 407813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407813&action=review >> Source/WebCore/platform/text/TextCodecSingleByte.h:32 >> +class TextCodecSingleByte : public TextCodec { > > I assume you didn’t mean to include this in this patch. I didn't.
Alex Christensen
Comment 4 2020-09-02 14:23:46 PDT
Created attachment 407814 [details] Patch
EWS
Comment 5 2020-09-02 20:28:56 PDT
Found 1 new test failure: fast/encoding/char-decoding.html
Darin Adler
Comment 6 2020-09-02 20:43:01 PDT
Looks like these two tests are failing on Windows: fast/encoding/char-decoding.html fast/encoding/charset-replacement.html Maybe they both need to be re-based?
Alex Christensen
Comment 7 2020-09-02 21:21:11 PDT
This change causes tests to fail. There's something wrong with it.
Darin Adler
Comment 8 2020-09-02 21:24:12 PDT
Comment on attachment 407814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407814&action=review > Source/WebCore/platform/text/TextCodecUTF16.cpp:79 > + if (U16_IS_LEAD(codeUnit)) { This needs to be U16_IS_TRAIL, not U16_IS_LEAD.
Alex Christensen
Comment 9 2020-09-02 22:30:47 PDT
Created attachment 407868 [details] Patch
EWS
Comment 10 2020-09-03 08:30:02 PDT
Committed r266517: <https://trac.webkit.org/changeset/266517> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407868 [details].
Radar WebKit Bug Importer
Comment 11 2020-09-03 08:31:14 PDT
<rdar://problem/68280790>
Note You need to log in before you can comment on or make changes to this bug.