Summary: | Use unicode macros instead of manual range checks in TextCodecUTF16 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alex Christensen
2020-09-02 14:18:19 PDT
Created attachment 407813 [details]
Patch
Comment on attachment 407813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407813&action=review > Source/WebCore/platform/text/TextCodecSingleByte.cpp:2 > + * Copyright (C) 2020 Apple Inc. All rights reserved. I assume you didn’t mean to include this in this patch. > Source/WebCore/platform/text/TextCodecSingleByte.h:32 > +class TextCodecSingleByte : public TextCodec { I assume you didn’t mean to include this in this patch. Comment on attachment 407813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407813&action=review >> Source/WebCore/platform/text/TextCodecSingleByte.h:32 >> +class TextCodecSingleByte : public TextCodec { > > I assume you didn’t mean to include this in this patch. I didn't. Created attachment 407814 [details]
Patch
Found 1 new test failure: fast/encoding/char-decoding.html Looks like these two tests are failing on Windows: fast/encoding/char-decoding.html fast/encoding/charset-replacement.html Maybe they both need to be re-based? This change causes tests to fail. There's something wrong with it. Comment on attachment 407814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407814&action=review > Source/WebCore/platform/text/TextCodecUTF16.cpp:79 > + if (U16_IS_LEAD(codeUnit)) { This needs to be U16_IS_TRAIL, not U16_IS_LEAD. Created attachment 407868 [details]
Patch
Committed r266517: <https://trac.webkit.org/changeset/266517> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407868 [details]. |