Bug 216063

Summary: Allow direct creation of replacement codec
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2020-09-01 19:37:17 PDT
Allow direct creation of replacement codec
Attachments
Patch (4.45 KB, patch)
2020-09-01 19:38 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.68 KB, patch)
2020-09-02 07:49 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (7.89 KB, patch)
2020-09-02 08:40 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-09-01 19:38:09 PDT
Created attachment 407732 [details] Patch
youenn fablet
Comment 2 2020-09-02 02:55:34 PDT
Some tests need rebasing, some tests need investigation (fast/encoding/charset-replacement.html).
Alex Christensen
Comment 3 2020-09-02 07:49:58 PDT
Created attachment 407765 [details] Patch
youenn fablet
Comment 4 2020-09-02 08:37:12 PDT
Comment on attachment 407765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407765&action=review > LayoutTests/imported/w3c/web-platform-tests/encoding/replacement-encodings.any-expected.txt:12 > +PASS replacement - non-empty input decodes to one replacement character. imported/w3c/web-platform-tests/encoding/replacement-encodings.any.worker-expected.txt might need rebasing as well.
Alex Christensen
Comment 5 2020-09-02 08:40:46 PDT
Created attachment 407770 [details] Patch
Alex Christensen
Comment 6 2020-09-02 08:52:42 PDT
http://trac.webkit.org/r266466
Radar WebKit Bug Importer
Comment 7 2020-09-02 08:53:14 PDT
<rdar://problem/68212529>
Darin Adler
Comment 8 2020-09-02 21:30:21 PDT
This test is broken on Windows now: fast/encoding/charset-replacement.html I think it needs to be rebased for Windows.
Alex Christensen
Comment 9 2020-09-02 22:28:15 PDT
https://trac.webkit.org/changeset/266504/webkit
Alex Christensen
Comment 10 2020-09-03 09:15:13 PDT
And iOS https://trac.webkit.org/changeset/266522/webkit
Alexey Proskuryakov
Comment 11 2020-09-03 17:47:21 PDT
Comment on attachment 407770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407770&action=review > LayoutTests/ChangeLog:9 > + * fast/encoding/charset-replacement-expected.txt: > + * fast/encoding/charset-replacement.html: Why was it necessary to make this test a render tree dump?
Darin Adler
Comment 12 2020-09-05 15:32:15 PDT
Comment on attachment 407770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407770&action=review >> LayoutTests/ChangeLog:9 >> + * fast/encoding/charset-replacement.html: > > Why was it necessary to make this test a render tree dump? That does seem like a step in the wrong direction.
Darin Adler
Comment 13 2020-09-05 15:32:16 PDT
Comment on attachment 407770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407770&action=review >> LayoutTests/ChangeLog:9 >> + * fast/encoding/charset-replacement.html: > > Why was it necessary to make this test a render tree dump? That does seem like a step in the wrong direction.
Note You need to log in before you can comment on or make changes to this bug.