Bug 216043

Summary: Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if Gigacage is not enabled
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, jbedard, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2020-09-01 10:15:32 PDT
Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if Gigacage is not enabled
Attachments
Patch (7.01 KB, patch)
2020-09-01 10:22 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-09-01 10:22:02 PDT
Created attachment 407692 [details] Patch
Yusuke Suzuki
Comment 2 2020-09-01 10:22:05 PDT
<rdar://problem/66394369>
Mark Lam
Comment 3 2020-09-01 10:46:20 PDT
Comment on attachment 407692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407692&action=review r=me with fix > Source/JavaScriptCore/tools/JSDollarVM.cpp:3124 > + return JSValue::encode(jsBoolean(Gigacage::isEnabled())); Can you add `DollarVMAssertScope assertScope;` before this line?
Yusuke Suzuki
Comment 4 2020-09-01 11:30:37 PDT
Comment on attachment 407692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407692&action=review Thanks! >> Source/JavaScriptCore/tools/JSDollarVM.cpp:3124 >> + return JSValue::encode(jsBoolean(Gigacage::isEnabled())); > > Can you add `DollarVMAssertScope assertScope;` before this line? Added.
Yusuke Suzuki
Comment 5 2020-09-01 19:18:10 PDT
Committed r266447: <https://trac.webkit.org/changeset/266447>
Note You need to log in before you can comment on or make changes to this bug.