Bug 215995

Summary: Update generateEmptyHeaderAndCpp in generate-bindings.pl to use proper English and use an #error to catch accidental compilation
Product: WebKit Reporter: Sam Weinig <sam>
Component: BindingsAssignee: Sam Weinig <sam>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: cdumez, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2020-08-30 18:25:19 PDT
As noted by Darin in https://bugs.webkit.org/show_bug.cgi?id=215992, we should update generateEmptyHeaderAndCpp in generate-bindings.pl to use proper English and use an #error to catch accidental compilation.
Attachments
Patch (9.56 KB, patch)
2020-08-30 19:15 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-08-30 19:15:38 PDT
Created attachment 407584 [details] Patch
Darin Adler
Comment 2 2020-08-31 09:29:19 PDT
Comment on attachment 407584 [details] Patch Looks ike these empty headers and file are indeed compiled, despite the comment saying they "must not".
Sam Weinig
Comment 3 2020-08-31 10:35:53 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 407584 [details] > Patch > > Looks ike these empty headers and file are indeed compiled, despite the > comment saying they "must not". Very much so :).
Radar WebKit Bug Importer
Comment 4 2020-09-06 18:26:18 PDT
<rdar://problem/68439122>
Sam Weinig
Comment 5 2020-09-14 14:10:35 PDT
I handled this in another bug.
Note You need to log in before you can comment on or make changes to this bug.