Bug 215968 – [WinCairo] Can't load xml2.dll and xslt.dll in v2020.08.20 of WebKitRequirementsWin64.zip

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Kagami Sascha Rosylight]

TestWebKit.exe fails with this message:

```
TestWebKit can't open.
::LoadLibraryW failed:
path=C:\Users\Kagami\Downloads\266319\TestWebKitLib.dll
The specified module could not be found.
```

This happens regardless of existence of WinCairoRequirements dlls. Somehow jsc.exe is the only executable that runs without errors.

I have a full Visual Studio 2019 installation, and followed "Download build artifacts from Buildbot" from https://trac.webkit.org/wiki/BuildingCairoOnWindows#DownloadbuildartifactsfromBuildbot.

[Fujii Hironori]

Could you check what is the missing DLL by using Dependencies?
https://github.com/lucasg/Dependencies

[Kagami Sascha Rosylight]

Dependencies does not support LoadLibrary:

> Dynamic loading via LoadLibrary are not supported (and probably won't ever be).

... and thus I could not find any problem with Dependencies. It only shows five system DLLs (SHLWAPI.dll, user32.dll, kernel32.dll, MSVC140.dll, VCRUNTIME140.dll) and five api-ms-win-crt ones.

[Fujii Hironori]

Oh, right. those exe files are using LoadLibrary.
Open TestWebKitLib.dll and MiniBrowserLib.dll instead of exe files.

[Kagami Sascha Rosylight]

Oops, did it and found these four DLLs are missing:

ext-ms-win-core-winrt-remote-l1-1-0.dll
ext-ms-win-com-apartmentrestriction-l1-1-0.dll
ext-ms-win-com-suspendresiliency-l1-1-0.dll
ext-ms-win-ro-typeresolution-l1-1-0.dll

[Fujii Hironori]

Created attachment 407546 [details]
output of dependencies.exe -chain

This is my result. I think NOT_FOUND of ext-* is not problem. 
However, the difference is ext-ms-win-com-apartmentrestriction-l1-1-0.dll is not in my list.

[Kagami Sascha Rosylight]

Created attachment 407547 [details]
./Dependencies.exe -chain

Attaching mine. Huge and hard to diff, hmm.

[Kagami Sascha Rosylight]

BTW, TestWebKitLib.dll is clean and my attached result is from MiniBrowserLib.dll.

Not sure why it still fails to load TestWebKitLib.dll.

[Fujii Hironori]

I'm sorry. I was checking old revision. I tried the same revision and fails to load MiniBrowser.

https://s3-us-west-2.amazonaws.com/archives.webkit.org/wincairo-x86_64-release/266319.zip
https://github.com/WebKitForWindows/WebKitRequirements/releases/tag/v2020.08.20

dependencies.exe correctly points out what are the missing DLL.
xml2.dll (NOT_FOUND)
xslt.dll (NOT_FOUND)

Those dll files are missing in v2020.08.20 of WebKitRequirementsWin64.zip.

[Fujii Hironori]

Use CMake files from upstream libxml2 repo (#36) · WebKitForWindows/WebKitRequirements@5429437
https://github.com/WebKitForWindows/WebKitRequirements/commit/5429437e8c3e59cf1c6cdbda313acfd70237bf08

Use CMake files from upstream libxslt repo (#37) · WebKitForWindows/WebKitRequirements@15c71c4
https://github.com/WebKitForWindows/WebKitRequirements/commit/15c71c4cb8b48d601a2016ab816ce31298d6e3d1

These changes seem the culprit.

[Don Olmstead]

The name of the dlls changed from xml2.dll to libxml2.dll. Those files are from the upstream repositories so they should probably be fixed so the prefix isn't there on windows.

[Fujii Hironori]

WinCairo bot still has stale import libs for xml2 and xslt.
I confirmed copying xml2.dll and xslt.dll from the previous WebKitRequirements can work around the loading issue.

https://github.com/WebKitForWindows/WebKitRequirements/releases/tag/v2020.07.01

[Stephan Szabo]

The old versions should now be gone on the builders, so builds starting with 266357 appear from dependencies -chain to be referring to libxml2 and libxslt.

We still need to make dealing with dependency removal/rename more automatic than needing to clear out the dependencies directory manually.

[Fujii Hironori]

Yeah, it works. Thank you, Steph. Closed this bug.

[Radar WebKit Bug Importer]

<rdar://problem/68093827>