Bug 215933

Summary: Remove the system tracing from DisplayList::Replayer::replay()
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Said Abou-Hallawa 2020-08-28 10:18:48 PDT
It turned out this tracing point can be expensive when drawing many text lines in a page. It can affect the tracing of the MotionMark Design test for example.
Comment 1 Said Abou-Hallawa 2020-08-28 10:24:08 PDT
Created attachment 407479 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-08-28 10:27:56 PDT
Comment on attachment 407479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407479&action=review

> Source/WTF/wtf/SystemTracing.h:-92
> -    DisplayListReplayStart,
> -    DisplayListReplayEnd,

Don't remove these, because the rest of the values will move and break viewing older traces.
Comment 3 Said Abou-Hallawa 2020-08-28 10:37:21 PDT
Created attachment 407482 [details]
Patch
Comment 4 EWS 2020-08-28 11:02:40 PDT
Committed r266286: <https://trac.webkit.org/changeset/266286>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407482 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-28 11:03:17 PDT
<rdar://problem/67950678>