Bug 215933

Summary: Remove the system tracing from DisplayList::Replayer::replay()
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Said Abou-Hallawa
Reported 2020-08-28 10:18:48 PDT
It turned out this tracing point can be expensive when drawing many text lines in a page. It can affect the tracing of the MotionMark Design test for example.
Attachments
Patch (2.67 KB, patch)
2020-08-28 10:24 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2020-08-28 10:37 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2020-08-28 10:24:08 PDT
Created attachment 407479 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-08-28 10:27:56 PDT
Comment on attachment 407479 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407479&action=review > Source/WTF/wtf/SystemTracing.h:-92 > - DisplayListReplayStart, > - DisplayListReplayEnd, Don't remove these, because the rest of the values will move and break viewing older traces.
Said Abou-Hallawa
Comment 3 2020-08-28 10:37:21 PDT
Created attachment 407482 [details] Patch
EWS
Comment 4 2020-08-28 11:02:40 PDT
Committed r266286: <https://trac.webkit.org/changeset/266286> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407482 [details].
Radar WebKit Bug Importer
Comment 5 2020-08-28 11:03:17 PDT
<rdar://problem/67950678>
Note You need to log in before you can comment on or make changes to this bug.