Bug 215913

Summary: TextManipulationController should use weak pointers to Node
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, kangil.han, mifenton, sihui_liu, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215914
Attachments:
Description Flags
Use WeakHashSet
none
Patch for landing none

Description Ryosuke Niwa 2020-08-27 23:18:52 PDT 
Now that https://trac.webkit.org/r266212 has been landed, use it in TextManipulationController.
Comment 1 Radar WebKit Bug Importer 2020-09-03 23:19:14 PDT 
<rdar://problem/68325953>
Comment 2 Ryosuke Niwa 2021-04-12 19:33:49 PDT 
Created attachment 425823 [details]
Use WeakHashSet
Comment 3 Ryosuke Niwa 2021-04-12 19:48:56 PDT 
Comment on attachment 425823 [details]
Use WeakHashSet

View in context: https://bugs.webkit.org/attachment.cgi?id=425823&action=review

> Source/WebCore/editing/TextManipulationController.cpp:934
>  void TextManipulationController::removeNode(Node* node)

I'll make this take Node& as we discussed.
Comment 4 Ryosuke Niwa 2021-04-12 20:44:52 PDT 
Created attachment 425827 [details]
Patch for landing
Comment 5 EWS 2021-04-12 21:19:24 PDT 
Committed r275859 (236424@main): <https://commits.webkit.org/236424@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425827 [details].