Summary: | [Linux] Web Inspector: show per thread cpu usage | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aperez, benjamin, bugs-noreply, cdumez, cmarcelo, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, ysuzuki | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2020-08-27 02:21:02 PDT
Created attachment 407386 [details]
Patch
This is failing in mac debug with the following error I don't understand: ERROR: WebCore has a weak external symbol in it (/Volumes/Data/worker/macOS-Mojave-Debug-Build-EWS/build/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore) ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library. ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file. ERROR: symbol __ZN3JSC16SamplingProfiler6threadEv Created attachment 407594 [details]
Try to fix mac debug builds
Shouldn't this be tagged [GTK][WPE]? Or maybe even [Linux]… the code touched by this patch is not specific to the GTK port 🤔️ Committed r266388: <https://trac.webkit.org/changeset/266388> |