Bug 215883

Summary: [Linux] Web Inspector: show per thread cpu usage
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, benjamin, bugs-noreply, cdumez, cmarcelo, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, ysuzuki
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Try to fix mac debug builds aperez: review+

Carlos Garcia Campos
Reported 2020-08-27 02:21:02 PDT
We only provide global cpu usage to the inspector, we don't exclude debugging threads (the resource usage and sampling profiler threads) and we don't classify the threads (Main, WebKit, others).
Attachments
Patch (15.36 KB, patch)
2020-08-27 02:27 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Try to fix mac debug builds (15.38 KB, patch)
2020-08-31 02:20 PDT, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-08-27 02:27:52 PDT
Created attachment 407386 [details] Patch
Carlos Garcia Campos
Comment 2 2020-08-27 03:37:29 PDT
This is failing in mac debug with the following error I don't understand: ERROR: WebCore has a weak external symbol in it (/Volumes/Data/worker/macOS-Mojave-Debug-Build-EWS/build/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore) ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library. ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file. ERROR: symbol __ZN3JSC16SamplingProfiler6threadEv
Carlos Garcia Campos
Comment 3 2020-08-31 02:20:24 PDT
Created attachment 407594 [details] Try to fix mac debug builds
Adrian Perez
Comment 4 2020-08-31 13:33:35 PDT
Shouldn't this be tagged [GTK][WPE]? Or maybe even [Linux]… the code touched by this patch is not specific to the GTK port 🤔️
Carlos Garcia Campos
Comment 5 2020-09-01 01:55:13 PDT
Committed r266388: <https://trac.webkit.org/changeset/266388>
Note You need to log in before you can comment on or make changes to this bug.