Summary: | REGRESSION: touchbar controls don't reflect video state in fullscreen | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Media | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, eric.carlson, hi, jer.noble, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=164789 | ||||||||
Attachments: |
|
Description
Devin Rousso
2020-08-26 16:41:28 PDT
Created attachment 407357 [details]
Patch
Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 42, in <module> from webkitpy.tool.main import WebKitPatch File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/main.py", line 41, in <module> from webkitpy.tool import commands File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/__init__.py", line 4, in <module> from webkitpy.tool.commands.analyzechangelog import AnalyzeChangeLog File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/analyzechangelog.py", line 39, in <module> from webkitpy.tool import steps File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/steps/__init__.py", line 56, in <module> from webkitpy.tool.steps.postdiffforrevert import PostDiffForRevert File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/steps/postdiffforrevert.py", line 29, in <module> from webkitpy.common.net.bugzilla import Attachment File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/net/bugzilla/__init__.py", line 4, in <module> from webkitpy.common.net.bugzilla.bugzilla import Bugzilla File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 51, in <module> from webkitpy.thirdparty.BeautifulSoup import BeautifulSoup, BeautifulStoneSoup, SoupStrainer File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 58, in <module> from webkitpy.thirdparty.BeautifulSoup_legacy import BeautifulSoup, BeautifulStoneSoup, SoupStrainer File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup_legacy.py", line 1735, in <module> import chardet File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 459, in find_module cls.install(name) File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 444, in install return to_install.install() File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 210, in install if not self.archives(): File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 117, in archives response = AutoInstall._request('https://{}/{}'.format(AutoInstall.index, path)) File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 320, in _request cafile=os.path.join(os.path.dirname(__file__), 'cacert.pem'), File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 154, in urlopen return opener.open(url, data, timeout) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 431, in open response = self._open(req, data) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 449, in _open '_open', req) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 409, in _call_chain result = func(*args) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 1240, in https_open context=self._context) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 1197, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 8] nodename nor servname provided, or not known> Created attachment 407364 [details]
Patch
Committed r266218: <https://trac.webkit.org/changeset/266218> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407364 [details]. |