Bug 215859

Summary: Make ImageDiff before TestWebKitAPI
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: NEW    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Alex Christensen
Reported 2020-08-26 12:35:47 PDT
Make ImageDiff before TestWebKitAPI
Attachments
Patch (1.44 KB, patch)
2020-08-26 12:36 PDT, Alex Christensen 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-08-26 12:36:27 PDT
Created attachment 407322 [details] Patch
Darin Adler
Comment 2 2020-08-26 14:48:44 PDT
Comment on attachment 407322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407322&action=review > Tools/ChangeLog:3 > + Make ImageDiff before TestWebKitAPI Given you are optimizing the sequence, why did you put it after MiniBrowser? > Tools/Makefile:5 > +ifeq (,$(DO_NOT_BUILD_IMAGE_DIFF)) > + MODULES += ImageDiff > +endif Would be nice to have a comment here, since it’s not obvious why we are adding ImageDiff to the middle.
Alex Christensen
Comment 3 2020-08-27 09:40:18 PDT
Comment on attachment 407322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407322&action=review >> Tools/ChangeLog:3 >> + Make ImageDiff before TestWebKitAPI > > Given you are optimizing the sequence, why did you put it after MiniBrowser? MiniBrowser doesn't take long to build, but you're right. That would be even better!
Radar WebKit Bug Importer
Comment 4 2020-09-02 12:36:16 PDT
<rdar://problem/68226453>
Note You need to log in before you can comment on or make changes to this bug.