Bug 21583

Summary:

Remove branches for CodeBlock and CTI code in function call logic

Product:

WebKit

Reporter:

Cameron Zwarich (cpst) <zwarich>

Component:

JavaScriptCore

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

barraclough

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

20812, 21584

Attachments:

Description	Flags
appease cpst	none
newer version of patch, although thoroughly broken	none
Yet another version	none

Cameron Zwarich (cpst)

Reported 2008-10-13 17:50:41 PDT

We should avoid branching to check the existence of a CodeBlock when doing a function call, as this will shorten the function call sequence and allow more logic to be inlined as machine code. We already have a trampoline for the JIT code, but a unified solution would be nice.

Attachments
appease cpst (11.30 KB, patch) 2008-10-15 19:33 PDT, Oliver Hunt	no flags	Details Formatted Diff Diff
newer version of patch, although thoroughly broken (10.00 KB, patch) 2008-10-17 21:25 PDT, Oliver Hunt	no flags	Details Formatted Diff Diff
Yet another version (9.94 KB, patch) 2008-10-21 14:30 PDT, Oliver Hunt	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2008-10-15 19:33:55 PDT

Created attachment 24383 [details] appease cpst This patch is not a significant win, and is likely to be a regression on a macbook, but i am putting it up to make cpst stop haranguing me :p

Oliver Hunt

Comment 2 2008-10-17 21:25:48 PDT

Created attachment 24477 [details] newer version of patch, although thoroughly broken Alas this is broken, but it's merged with ToT. Curse you gbarra!!!11!!one!!!

Oliver Hunt

Comment 3 2008-10-21 14:30:50 PDT

Created attachment 24546 [details] Yet another version Bought up to ToT again, still does not work. Has not worked since gavin's patch. I'm off to work on orther things.

Cameron Zwarich (cpst)

Comment 4 2009-04-19 01:48:56 PDT

This has been fixed since, hasn't it? Or is there some piece of it that I am missing?

Gavin Barraclough

Comment 5 2012-03-07 00:01:45 PST

These patches are archaic and the JIT has clearly changed a lot. This bug is not something we're planning on doing right now, and is not tracking anything useful.

Note You need to log in before you can comment on or make changes to this bug.