Bug 215760

Summary: Invalid early error for object literal method named "__proto__"
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Trivial CC: ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215769
Bug Depends on: 145138    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Alexey Shvayka
Reported 2020-08-23 13:54:03 PDT
Invalid early error for object literal method named "__proto__"
Attachments
Patch (36.04 KB, patch)
2020-08-23 18:14 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (36.01 KB, patch)
2020-08-25 00:30 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-08-23 18:14:50 PDT
Created attachment 407084 [details] Patch
Ross Kirsling
Comment 2 2020-08-24 09:45:10 PDT
Comment on attachment 407084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407084&action=review r=me, this seems like a nice cleanup. > Source/JavaScriptCore/parser/SyntaxChecker.h:107 > + ALWAYS_INLINE Property(PropertyNode::Type type, bool isUnderscoreProtoSetter = false) nit: I'm not certain that a default param value is really better than a default field value here?
Alexey Shvayka
Comment 3 2020-08-25 00:30:30 PDT
Created attachment 407179 [details] Patch
Alexey Shvayka
Comment 4 2020-08-25 00:31:26 PDT
Comment on attachment 407179 [details] Patch (In reply to Ross Kirsling from comment #2) > r=me, this seems like a nice cleanup. I appreciate you reviewing this, Ross! The diff is quite tough. > nit: I'm not certain that a default param value is really better than a > default field value here? I've moved the default value to field initializer (TIL `struct` can also do that), and brought back the `type` field. PropertyNode::Type is the same size as `bool`, yet it's more useful to have (unlike `name`).
EWS
Comment 5 2020-08-25 08:58:45 PDT
Committed r266117: <https://trac.webkit.org/changeset/266117> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407179 [details].
Radar WebKit Bug Importer
Comment 6 2020-08-25 08:59:17 PDT
<rdar://problem/67740285>
Note You need to log in before you can comment on or make changes to this bug.