| Summary: | Invalid early error for object literal method named "__proto__" | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||
| Component: | JavaScriptCore | Assignee: | Alexey Shvayka <ashvayka> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Trivial | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar, WebExposed | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=215769 | ||||||||
| Bug Depends on: | 145138 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Alexey Shvayka
2020-08-23 13:54:03 PDT
Created attachment 407084 [details]
Patch
Comment on attachment 407084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407084&action=review r=me, this seems like a nice cleanup. > Source/JavaScriptCore/parser/SyntaxChecker.h:107 > + ALWAYS_INLINE Property(PropertyNode::Type type, bool isUnderscoreProtoSetter = false) nit: I'm not certain that a default param value is really better than a default field value here? Created attachment 407179 [details]
Patch
Comment on attachment 407179 [details] Patch (In reply to Ross Kirsling from comment #2) > r=me, this seems like a nice cleanup. I appreciate you reviewing this, Ross! The diff is quite tough. > nit: I'm not certain that a default param value is really better than a > default field value here? I've moved the default value to field initializer (TIL `struct` can also do that), and brought back the `type` field. PropertyNode::Type is the same size as `bool`, yet it's more useful to have (unlike `name`). Committed r266117: <https://trac.webkit.org/changeset/266117> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407179 [details]. |