Bug 215689

Summary: [Cocoa] Unify implementation of custom font name aliases between all Cocoa platforms
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Myles C. Maxfield
Reported 2020-08-19 22:35:59 PDT
[Cocoa] Unify implementation of custom font name aliases between all Cocoa platforms
Attachments
Patch (23.36 KB, patch)
2020-08-19 22:37 PDT, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2020-08-19 22:37:11 PDT
Created attachment 406918 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-08-26 22:36:14 PDT
<rdar://problem/67851826>
Darin Adler
Comment 3 2020-09-05 08:54:11 PDT
Comment on attachment 406918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406918&action=review Nice improvement. > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311 > + RetainPtr<CFNumberRef> numberSpacingNumber = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &numberSpacingType)); auto > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1312 > + RetainPtr<CFNumberRef> monospacedNumbersNumber = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &monospacedNumbersSelector)); auto > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1313 > + RetainPtr<CTFontDescriptorRef> systemFontDescriptor = adoptCF(CTFontDescriptorCreateForUIType(kCTFontUIFontSystem, size, nullptr)); auto > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1314 > + RetainPtr<CTFontDescriptorRef> monospaceFontDescriptor = adoptCF(CTFontDescriptorCreateCopyWithFeature(systemFontDescriptor.get(), numberSpacingNumber.get(), monospacedNumbersNumber.get())); auto
Myles C. Maxfield
Comment 4 2020-09-05 10:51:13 PDT
Committed r266663: <https://trac.webkit.org/changeset/266663>
Note You need to log in before you can comment on or make changes to this bug.