Bug 215687

Summary: [Cocoa] CTFontIsSystemUIFont() is faster than CTFontDescriptorIsSystemUIFont()/CTFontCopyFontDescriptor()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
darin: review+
Patch for committing
none
Patch for committing none

Myles C. Maxfield
Reported 2020-08-19 21:40:03 PDT
[Cocoa] CTFontIsSystemUIFont() is faster than CTFontDescriptorIsSystemUIFont()/CTFontCopyFontDescriptor()
Attachments
Patch (7.54 KB, patch)
2020-08-19 21:42 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (7.53 KB, patch)
2020-08-19 21:54 PDT, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
Patch for committing (7.62 KB, patch)
2020-09-05 01:40 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for committing (7.61 KB, patch)
2020-09-05 01:49 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2020-08-19 21:42:24 PDT
Created attachment 406915 [details] Patch
Myles C. Maxfield
Comment 2 2020-08-19 21:44:37 PDT
<rdar://problem/59295639>
Myles C. Maxfield
Comment 3 2020-08-19 21:54:56 PDT
Created attachment 406916 [details] Patch
Darin Adler
Comment 4 2020-08-19 22:02:24 PDT
Comment on attachment 406916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406916&action=review > Source/WTF/wtf/PlatformUse.h:310 > +#if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 110000) > +#define USE_CTFONTISSYSTEMUIFONT 1 > +#endif Is this a USE or a HAVE? > Source/WebCore/platform/graphics/FontPlatformData.h:132 > + static bool isSystemFont(CTFontRef); Does this benefit from being a member function? Why not just a "free function" in this file?
Myles C. Maxfield
Comment 5 2020-09-05 01:40:42 PDT
Created attachment 408075 [details] Patch for committing
Myles C. Maxfield
Comment 6 2020-09-05 01:49:35 PDT
Created attachment 408076 [details] Patch for committing
EWS
Comment 7 2020-09-05 11:21:26 PDT
Committed r266667: <https://trac.webkit.org/changeset/266667> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408076 [details].
Note You need to log in before you can comment on or make changes to this bug.