Summary: | Don't depend on the suggested filename for image document titles | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brett Wilson (Google) <brettw> | ||||
Component: | Images | Assignee: | Brett Wilson (Google) <brettw> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brett Wilson (Google)
2008-10-12 20:11:10 PDT
Created attachment 24371 [details]
Patch
Use the fiename of the image URL as the title, which matches Firefox.
This uses the hostname as the fallback when there is no path component to use as the title. We can also fall back to the full URL, but that seemed like it would be longer and is not likely to contain more information.
I'm not sure this was the right fix. Chromium has issues with other cases besides image documents, such as HTML documents with no <title> and files handled by plugins. The Chromium code is being fixed to handle all these in one change. It may be reasonable for images to do something special anyway, e.g. "foo.gif (GIF image, 200x192)", but just setting a title to the filename seems like something the port can do automatically when the document has no title (or else that can happen somewhere less low-level than here). Thoughts? |