Bug 215635
| Summary: | [CSS Selector] Unknown combinator is not addressed correctly in |CSSSelectorParser::consumeComplexSelector| | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Joonghun Park <jh718.park> |
| Component: | CSS | Assignee: | Joonghun Park <jh718.park> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, jh718.park, koivisto, ntim, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://github.com/WebKit/WebKit/pull/14009 | ||
Joonghun Park
CSS Selector unknown combinator is not addressed properly.
For example, as in https://jsfiddle.net/zhp5o1a7/, if execute below code,
<html>
<style>@supports selector(A | .B) { #test {color: red}}</style>
<div id="test">test</div>
<script>console.log(CSS.supports("selector(A | .B)"));</script>
</html>
@supports selector(A | .B) function indicates that A | .B is supported css selector.
If I put some printf statements like this,
bool CSSSelectorParser::supportsComplexSelector(CSSParserTokenRange range, const CSSParserContext& context)
{
range.consumeWhitespace();
CSSSelectorParser parser(context, nullptr);
printf("CSSSelectorParser::supportsComplexSelector: %s\n", range.serialize().utf8().data());
auto parserSelector = parser.consumeComplexSelector(range);
if (parser.m_failedParsing || !range.atEnd() || !parserSelector)
return false;
auto complexSelector = parserSelector->releaseSelector();
printf("complexSelector: %s\n", complexSelector->value().string().utf8().data());
ASSERT(complexSelector);
if (containsUnknownWebKitPseudoElements(*complexSelector))
return false;
return true;
}
below logs are printed.
CSSSelectorParser::supportsComplexSelector: A | .B
complexSelector: B
So, it seems that |CSSSelectorParser::consumeComplexSelector| doesn't address the unknown combinator correctly.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/67430608>
Ahmad Saleem
I am able to reproduce this bug in WebKit ToT (mini browser), it shows 'red' text and in console, it shows 'true'. While Chrome Canary 115 and Firefox Nightly 115 show 'false' and not 'red' color text.
EWS
Committed 264246@main (cef7548f6339): <https://commits.webkit.org/264246@main>
Reviewed commits have been landed. Closing PR #14009 and removing active labels.