Bug 215586

Summary:

Turn off wheel event regions until we need them

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Scrolling

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, darin, ews-watchlist, fred.wang, jamesr, koivisto, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Simon Fraser (smfr) 2020-08-17 15:13:28 PDT

Disable the #if ENABLE(WHEEL_EVENT_REGIONS) code path until we actually start using it for passive/active wheel event region detection.

Comment 1 Simon Fraser (smfr) 2020-08-17 15:18:57 PDT

Created attachment 406746 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2020-08-17 15:19:59 PDT

<rdar://problem/67274794>

Comment 3 Simon Fraser (smfr) 2020-08-17 15:30:42 PDT

Created attachment 406748 [details]
Patch

Comment 4 Darin Adler 2020-08-17 17:31:39 PDT

Comment on attachment 406748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406748&action=review

> LayoutTests/platform/mac-wk2/TestExpectations:1079
> +webkit.org/b/215586 fast/scrolling/mac/wheel-event-listener-region-basic.html [ Skip ]
> +webkit.org/b/215586 fast/scrolling/mac/wheel-event-listener-region-document.html [ Skip ]
> +webkit.org/b/215586 fast/scrolling/mac/wheel-event-listener-region-element-invalidation.html [ Skip ]
> +webkit.org/b/215586 fast/scrolling/mac/wheel-event-listener-region-inside-overflow-scroll-clipped-out.html [ Skip ]
> +webkit.org/b/215586 fast/scrolling/mac/wheel-event-listener-region-inside-overflow-scroll.html [ Skip ]
> +webkit.org/b/215586 fast/scrolling/mac/wheel-event-listener-region-layer-offset.html [ Skip ]
> +webkit.org/b/215586 fast/scrolling/mac/wheel-event-listener-region-root-invalidation.html [ Skip ]
> +webkit.org/b/215586 fast/scrolling/mac/wheel-event-listener-region-window.html [ Skip ]

Seems like we should put these into a directory so we don’t have to list all of them.

Comment 5 EWS 2020-08-18 10:00:04 PDT

Committed r265823: <https://trac.webkit.org/changeset/265823>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406748 [details].