Bug 215554

Summary: JSDOMConstructorNotConstructable should be a constructor
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
darin: review+
Patch
none
Patch none

Yusuke Suzuki
Reported 2020-08-16 17:07:49 PDT
JSDOMConstructorNotConstructable should be a constructor
Attachments
Patch (3.40 KB, patch)
2020-08-16 17:08 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (3.81 KB, patch)
2020-08-16 17:12 PDT, Yusuke Suzuki 		darin: review+
DetailsFormatted DiffDiff
Patch (190.23 KB, patch)
2020-08-16 22:38 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (364.15 KB, patch)
2020-08-16 23:30 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-08-16 17:08:29 PDT
Created attachment 406690 [details] Patch
Yusuke Suzuki
Comment 2 2020-08-16 17:08:31 PDT
<rdar://problem/65770688>
Yusuke Suzuki
Comment 3 2020-08-16 17:12:37 PDT
Created attachment 406691 [details] Patch
Darin Adler
Comment 4 2020-08-16 17:18:49 PDT
Comment on attachment 406691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406691&action=review > LayoutTests/ChangeLog:10 > + * js/dom/window-is-constructor-expected.txt: Added. > + * js/dom/window-is-constructor.html: Added. Should this be in WPT instead?
Yusuke Suzuki
Comment 5 2020-08-16 22:37:11 PDT
Comment on attachment 406691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406691&action=review >> LayoutTests/ChangeLog:10 >> + * js/dom/window-is-constructor.html: Added. > > Should this be in WPT instead? Sounds good.
Yusuke Suzuki
Comment 6 2020-08-16 22:38:46 PDT
Created attachment 406698 [details] Patch Collecting updated expected files
Yusuke Suzuki
Comment 7 2020-08-16 23:30:26 PDT
Created attachment 406699 [details] Patch Collecting updated expected files
Yusuke Suzuki
Comment 8 2020-08-17 00:37:19 PDT
Committed r265749: <https://trac.webkit.org/changeset/265749>
Note You need to log in before you can comment on or make changes to this bug.