Bug 215544

Summary: Use more enum classes in DateComponents
Product: WebKit Reporter: Rob Buis <rbuis>
Component: DOMAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, mifenton, pdr, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2020-08-15 13:06:48 PDT
Make Type and SecondFormat enum classes since this is more readable and allows us to have less includes in header files.
Attachments
Patch (34.01 KB, patch)
2020-08-15 13:38 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (34.87 KB, patch)
2020-08-15 13:55 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (36.57 KB, patch)
2020-08-16 05:33 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-08-15 13:38:00 PDT
Created attachment 406674 [details] Patch
Rob Buis
Comment 2 2020-08-15 13:55:52 PDT
Created attachment 406675 [details] Patch
Darin Adler
Comment 3 2020-08-15 14:24:22 PDT
Comment on attachment 406675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406675&action=review > Source/WebCore/platform/DateComponents.h:39 > +enum class SecondFormat { I suggest adding ": uint8_t". > Source/WebCore/platform/DateComponents.h:45 > +enum class DateComponentsType { I suggest adding ": uint8_t".
Rob Buis
Comment 4 2020-08-16 05:33:15 PDT
Created attachment 406683 [details] Patch
Rob Buis
Comment 5 2020-08-16 12:40:45 PDT
Comment on attachment 406675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406675&action=review >> Source/WebCore/platform/DateComponents.h:39 >> +enum class SecondFormat { > > I suggest adding ": uint8_t". Done. >> Source/WebCore/platform/DateComponents.h:45 >> +enum class DateComponentsType { > > I suggest adding ": uint8_t". Done.
Radar WebKit Bug Importer
Comment 6 2020-08-22 13:07:16 PDT
<rdar://problem/67622319>
EWS
Comment 7 2020-08-25 08:29:17 PDT
Committed r266114: <https://trac.webkit.org/changeset/266114> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406683 [details].
Note You need to log in before you can comment on or make changes to this bug.