Summary: | Scrolling sync changes in r261985 regressed CPU usage by ~2 ms/s | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarcelo, ews-watchlist, fred.wang, ggaren, jamesr, luiz, nham, simon.fraser, thorton, tonikitoo, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2020-08-14 18:13:54 PDT
Created attachment 406641 [details]
Patch
Comment on attachment 406641 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406641&action=review r=me > Source/WebCore/page/scrolling/ScrollingTree.h:212 > + bool isRecentlyActive(); > + WEBCORE_EXPORT void setRecentlyActive(); Should we make these names more specific to wheel events? isProcessingWheelEvent() willProcessWheelEvent() > Source/WebCore/page/scrolling/ScrollingTree.h:278 > + Lock m_lastEventTimeMutex; > + MonotonicTime m_lastEventTime; Should we make these names more specific to wheel events? m_lastWheelEventTimeMutex m_lastWheelEventTime (In reply to Geoffrey Garen from comment #3) > Comment on attachment 406641 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406641&action=review > > r=me > > > Source/WebCore/page/scrolling/ScrollingTree.h:212 > > + bool isRecentlyActive(); > > + WEBCORE_EXPORT void setRecentlyActive(); > > Should we make these names more specific to wheel events? > > isProcessingWheelEvent() > willProcessWheelEvent() > > > Source/WebCore/page/scrolling/ScrollingTree.h:278 > > + Lock m_lastEventTimeMutex; > > + MonotonicTime m_lastEventTime; > > Should we make these names more specific to wheel events? > > m_lastWheelEventTimeMutex > m_lastWheelEventTime Perhaps, though the ScrollingThread exists only to process wheel events, so I don't feel the need to qualify further. |