Bug 215512

Summary: [ARMv7][JSC] Conservative GC is not considering `r7` as a root
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Caio Lima
Reported 2020-08-14 10:26:27 PDT
We need to consider callee-saved registers as a root for conservative GC, but we are skipping `r7` on ARMv7.
Attachments
Patch (1.75 KB, patch)
2020-08-14 10:38 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2020-08-14 11:47 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2020-08-14 10:38:50 PDT
Created attachment 406603 [details] Patch
Caio Lima
Comment 2 2020-08-14 10:40:30 PDT
The motivation for this patch is a crash on WPE 2.22 <https://github.com/WebPlatformForEmbedded/WPEWebKit/issues/655>.
Yusuke Suzuki
Comment 3 2020-08-14 10:43:12 PDT
Comment on attachment 406603 [details] Patch r=me
Mark Lam
Comment 4 2020-08-14 10:43:41 PDT
Comment on attachment 406603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406603&action=review > Source/JavaScriptCore/ChangeLog:8 > + Since `r7` is a calle-saved register on ARMv7 /calle/callee/
Caio Lima
Comment 5 2020-08-14 11:47:49 PDT
Created attachment 406611 [details] Patch
EWS
Comment 6 2020-08-14 12:13:26 PDT
Committed r265692: <https://trac.webkit.org/changeset/265692> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406611 [details].
Radar WebKit Bug Importer
Comment 7 2020-08-14 12:14:18 PDT
<rdar://problem/67088331>
Note You need to log in before you can comment on or make changes to this bug.