Bug 215512

Summary: [ARMv7][JSC] Conservative GC is not considering `r7` as a root
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Caio Lima 2020-08-14 10:26:27 PDT 
We need to consider callee-saved registers as a root for conservative GC, but we are skipping `r7` on ARMv7.
Comment 1 Caio Lima 2020-08-14 10:38:50 PDT 
Created attachment 406603 [details]
Patch
Comment 2 Caio Lima 2020-08-14 10:40:30 PDT 
The motivation for this patch is a crash on WPE 2.22 <https://github.com/WebPlatformForEmbedded/WPEWebKit/issues/655>.
Comment 3 Yusuke Suzuki 2020-08-14 10:43:12 PDT 
Comment on attachment 406603 [details]
Patch

r=me
Comment 4 Mark Lam 2020-08-14 10:43:41 PDT 
Comment on attachment 406603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406603&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Since `r7` is a calle-saved register on ARMv7

/calle/callee/
Comment 5 Caio Lima 2020-08-14 11:47:49 PDT 
Created attachment 406611 [details]
Patch
Comment 6 EWS 2020-08-14 12:13:26 PDT 
Committed r265692: <https://trac.webkit.org/changeset/265692>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406611 [details].
Comment 7 Radar WebKit Bug Importer 2020-08-14 12:14:18 PDT 
<rdar://problem/67088331>