Bug 215507

Summary:

AX: implement prefers-contrast: more

Product:

WebKit

Reporter:

James Craig <jcraig>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cfleizach, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, macpherson, menard, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	ews-feeder: commit-queue-
patch	ews-feeder: commit-queue-
patch	ews-feeder: commit-queue-
patch	none
patch	none

James Craig

Reported 2020-08-14 09:28:13 PDT

Spec: https://drafts.csswg.org/mediaqueries-5/#prefers-contrast Note: the new `more` value used to be called `high` (hanged because high is a decent name for the Windows implementation, but not the Mac or iOS one) The `low` and `forced` values will be no-ops on Apple platforms... Not sure about GTK. More details about the new resolution: https://github.com/w3c/csswg-drafts/issues/2943

Attachments
patch (31.93 KB, patch) 2020-12-10 11:15 PST, chris fleizach	ews-feeder: commit-queue-	Details Formatted Diff Diff
patch (33.03 KB, patch) 2020-12-10 11:43 PST, chris fleizach	ews-feeder: commit-queue-	Details Formatted Diff Diff
patch (41.18 KB, patch) 2020-12-10 15:33 PST, chris fleizach	ews-feeder: commit-queue-	Details Formatted Diff Diff
patch (41.16 KB, patch) 2020-12-11 22:22 PST, chris fleizach	no flags	Details Formatted Diff Diff
patch (39.09 KB, patch) 2020-12-14 13:32 PST, chris fleizach	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-08-14 09:28:34 PDT

<rdar://problem/67077492>

James Craig

Comment 2 2020-08-14 09:29:11 PDT

Typo: "hanged" = "changed" 😳

chris fleizach

Comment 3 2020-12-10 11:15:48 PST

Created attachment 415904 [details] patch

chris fleizach

Comment 4 2020-12-10 11:43:26 PST

Created attachment 415908 [details] patch

chris fleizach

Comment 5 2020-12-10 15:33:03 PST

Created attachment 415938 [details] patch

chris fleizach

Comment 6 2020-12-11 22:22:14 PST

Created attachment 416092 [details] patch

Dean Jackson

Comment 7 2020-12-14 10:23:59 PST

Comment on attachment 416092 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=416092&action=review > LayoutTests/ChangeLog:16 > + * fast/media/mq-prefers-contrast-forced-value.html: Added. > + * fast/media/mq-prefers-contrast-live-update-for-listener-expected.txt: Added. > + * fast/media/mq-prefers-contrast-live-update-for-listener.html: Added. > + * fast/media/mq-prefers-contrast-live-update.html: Added. > + * fast/media/mq-prefers-contrast-matchMedia-expected.txt: Added. > + * fast/media/mq-prefers-contrast-matchMedia.html: Added. > + * fast/media/mq-prefers-contrast.html: Added. All these expected files should be HTML ref tests. > LayoutTests/platform/ios-simulator/fast/media/mq-prefers-contrast-expected.txt:5 > +layer at (0,0) size 800x600 > + RenderView at (0,0) size 800x600 > +layer at (0,0) size 800x600 > + RenderBlock {HTML} at (0,0) size 800x600 > + RenderBody {BODY} at (8,8) size 784x576 We should do all these as ref rests. e.g. make LayoutTests/fast/media/mq-prefers-contrast-expected.html with the hardcoded results.

chris fleizach

Comment 8 2020-12-14 13:32:15 PST

Created attachment 416192 [details] patch

chris fleizach

Comment 9 2020-12-14 13:33:15 PST

> All these expected files should be HTML ref tests. > Thanks, moved most of these to ref tests. One exception was mq-prefers-contrast-live-update-for-listener.html which leverages the test infrasture like shouldBeTrue

EWS

Comment 10 2020-12-14 22:29:23 PST

Committed r270823: <https://trac.webkit.org/changeset/270823> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416192 [details].

Note You need to log in before you can comment on or make changes to this bug.