Bug 215420

Summary:	Clean up the VideoFullscreenModelClient management in VideoFullscreenModelContext
Product:	WebKit	Reporter:	Peng Liu <peng.liu6>
Component:	Media	Assignee:	Peng Liu <peng.liu6>
Status:	NEW
Severity:	Normal	CC:	eric.carlson, jer.noble, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Peng Liu

Reported 2020-08-12 11:37:02 PDT

We should replace `HashSet<WebCore::VideoFullscreenModelClient*>` with `WeakHashSet<WebCore::VideoFullscreenModelClient>` and update all the call sites. This may be a source of latent bugs, if the m_clients set is mutated while calling callbacks. https://bugs.webkit.org/show_bug.cgi?id=215305#c8

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-08-19 11:37:13 PDT

<rdar://problem/67415826>

Note You need to log in before you can comment on or make changes to this bug.