Bug 215413

Summary: Invalid early errors for class methods named "constructor" and "prototype"
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Trivial CC: darin, ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=142563
Attachments:
Description Flags
Patch
none
Patch none

Alexey Shvayka
Reported 2020-08-12 08:55:45 PDT
Incorrect early errors for class methods named "constructor" and "prototype"
Attachments
Patch (6.68 KB, patch)
2020-08-12 08:58 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (8.26 KB, patch)
2020-08-20 14:06 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-08-12 08:58:00 PDT
Created attachment 406458 [details] Patch
Alexey Shvayka
Comment 2 2020-08-12 09:06:37 PDT
"prototype" instance method tests are coming in https://github.com/tc39/test262/pull/2724: I will make sure to sync test262 first. Test coverage for r181404 (removed FIXME): JSTests/test262/test/language/expressions/class/elements/syntax/early-errors/grammar-special-meth-contains-super-*.js.
Radar WebKit Bug Importer
Comment 3 2020-08-19 08:56:25 PDT
<rdar://problem/67406058>
Alexey Shvayka
Comment 4 2020-08-20 14:06:43 PDT
Created attachment 406965 [details] Patch Rebase on top of synced test262 suites.
EWS
Comment 5 2020-08-20 14:37:44 PDT
Committed r265966: <https://trac.webkit.org/changeset/265966> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406965 [details].
Note You need to log in before you can comment on or make changes to this bug.