Summary: | Move RegisterFile growth check to callee | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cameron Zwarich (cpst) <zwarich> | ||||||||||||
Component: | JavaScriptCore | Assignee: | Cameron Zwarich (cpst) <zwarich> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | barraclough, mjs | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 20812 | ||||||||||||||
Attachments: |
|
Description
Cameron Zwarich (cpst)
2008-10-10 19:30:57 PDT
Created attachment 24287 [details]
Patch in progress
Created attachment 24288 [details]
Patch in progress
This is a 1.1% progression on SunSpider and a wash on V8. However, it is a significant speedup on DeltaBlue and Earley-Boyer, and only a wash because of a massive (hopefully random) slowdown on Richards.
I still need to implement the exception-handling correctly, and there might be a better way to do the branch to the slow case at the start of a function.
Here are the results on the V8 harness. Before: Richards: 1530 DeltaBlue: 1165 Crypto: 2140 RayTrace: 1439 EarleyBoyer: 2894 ---- Score (version 2): 1739 After: Richards: 1640 DeltaBlue: 1216 Crypto: 2109 RayTrace: 1454 EarleyBoyer: 2939 ---- Score (version 2): 1782 Created attachment 24289 [details]
SunSpider harness results
Created attachment 24324 [details]
Proposed patch
Created attachment 24326 [details]
Proposed patch
Oops. I accidentally removed a comment that is useful in cti_op_construct_JSConstruct.
Comment on attachment 24326 [details]
Proposed patch
r=me
|