Summary: | Web Inspector: breakpoint condition should be evaluated before the ignore count | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 215362 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Devin Rousso
2020-08-11 02:54:09 PDT
Created attachment 407039 [details]
Patch
Comment on attachment 407039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407039&action=review r=me > Source/JavaScriptCore/debugger/Breakpoint.cpp:78 > + return debugger.evaluateBreakpointCondition(*this, globalObject) && ++m_hitCount > m_ignoreCount; I find this one line unnecessarily complicated when all combined on one line. I'd break it up kinda like it was before Created attachment 407209 [details]
Patch
Committed r266138: <https://trac.webkit.org/changeset/266138> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407209 [details]. |