Bug 215312

Summary: REGRESSION(r263195): Revert all related GC Bitmap changes because some of perf is not fully recovered
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 213071, 213345, 215285    
Attachments:
Description Flags
REVERT of r263195 none

WebKit Commit Bot
Reported 2020-08-09 02:06:57 PDT
https://trac.webkit.org/changeset/263195 broke the build: Revert all related GC Bitmap changes because some of perf is not fully recovered This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
REVERT of r263195 (54.40 KB, patch)
2020-08-09 02:07 PDT, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2020-08-09 02:07:08 PDT
Created attachment 406265 [details] REVERT of r263195 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Yusuke Suzuki
Comment 2 2020-08-09 02:14:12 PDT
It is still possible that performance plot fluctuation is showing this not fully recovered, but anyway, reverting is just fine.
EWS
Comment 3 2020-08-09 04:49:16 PDT
Committed r265416: <https://trac.webkit.org/changeset/265416> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406265 [details].
Radar WebKit Bug Importer
Comment 4 2020-08-09 04:50:19 PDT
<rdar://problem/66745699>
Note You need to log in before you can comment on or make changes to this bug.