Bug 215290

Summary:

[macOS] It should be possible to override spellchecking results in WebKitTestRunner

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

Tools / Tests

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, hi, megan_gardner, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	hi: review+
Patch for landing	none

Wenson Hsieh

Reported 2020-08-07 13:28:10 PDT

SSIA

Attachments
Patch (30.34 KB, patch) 2020-08-07 13:43 PDT, Wenson Hsieh	hi: review+	Details Formatted Diff Diff
Patch for landing (30.42 KB, patch) 2020-08-07 15:30 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2020-08-07 13:43:58 PDT

Created attachment 406207 [details] Patch

Devin Rousso

Comment 2 2020-08-07 15:22:17 PDT

Comment on attachment 406207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406207&action=review r=me > LayoutTests/editing/spelling/markers.html:83 > + element = e; NIT: rather than declare the globals using `let`, I think you can use `window.element = null` and then just set `window.element = element` (changing `e` to `element`) here to avoid the naming collision/confusion :) > LayoutTests/editing/spelling/markers.html:92 > + misspellingData = misspelling; ditto (:83) > LayoutTests/editing/spelling/markers.html:109 > + element = e; ditto (:83) > LayoutTests/editing/spelling/markers.html:118 > + misspellingData = misspelling; ditto (:83) > LayoutTests/editing/spelling/markers.html:123 > + oppositeMarker = "spelling"; ditto (:83) > LayoutTests/editing/spelling/markers.html:125 > + oppositeMarker = "grammar"; ditto (:83)

Wenson Hsieh

Comment 3 2020-08-07 15:25:44 PDT

Comment on attachment 406207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406207&action=review >> LayoutTests/editing/spelling/markers.html:83 >> + element = e; > > NIT: rather than declare the globals using `let`, I think you can use `window.element = null` and then just set `window.element = element` (changing `e` to `element`) here to avoid the naming collision/confusion :) Sounds good! >> LayoutTests/editing/spelling/markers.html:92 >> + misspellingData = misspelling; > > ditto (:83) 👍🏻 >> LayoutTests/editing/spelling/markers.html:109 >> + element = e; > > ditto (:83) 👍🏻 >> LayoutTests/editing/spelling/markers.html:118 >> + misspellingData = misspelling; > > ditto (:83) 👍🏻 >> LayoutTests/editing/spelling/markers.html:123 >> + oppositeMarker = "spelling"; > > ditto (:83) 👍🏻 >> LayoutTests/editing/spelling/markers.html:125 >> + oppositeMarker = "grammar"; > > ditto (:83) 👍🏻

Wenson Hsieh

Comment 4 2020-08-07 15:30:58 PDT

Created attachment 406219 [details] Patch for landing

EWS

Comment 5 2020-08-07 16:05:42 PDT

Committed r265396: <https://trac.webkit.org/changeset/265396> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406219 [details].

Radar WebKit Bug Importer

Comment 6 2020-08-07 16:06:34 PDT

<rdar://problem/66704754>

Note You need to log in before you can comment on or make changes to this bug.