Bug 215289

Summary:

AudioContext / OfflineAudioContext should support a wider sample rate range

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, clark_wang, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, pnormand, sergio, vjaquez, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

212611, 215301

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2020-08-07 13:11:26 PDT

AudioContext / OfflineAudioContext should support a wider sample rate range. A lot of WPT tests are failing because we support a much smaller range of sample rates than other browsers.

Attachments
Patch (323.76 KB, patch) 2020-08-07 14:15 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (326.39 KB, patch) 2020-08-07 14:49 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (326.48 KB, patch) 2020-08-07 14:53 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (333.21 KB, patch) 2020-08-07 15:37 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (333.00 KB, patch) 2020-08-07 16:36 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (333.93 KB, patch) 2020-08-07 17:11 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2020-08-07 14:15:22 PDT

Created attachment 406211 [details] Patch

Eric Carlson

Comment 2 2020-08-07 14:31:57 PDT

Comment on attachment 406211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406211&action=review > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:108 > bool BaseAudioContext::isSampleRateRangeGood(float sampleRate) This isn't new, but`isSampleRateRangeGood` isn't a great name. What is a "good" sample rate, one that renders natively, or one that sounds good, or ... `isSampleRateSupported` or `isSupportedSampleRate` would be a better name.

Chris Dumez

Comment 3 2020-08-07 14:49:49 PDT

Created attachment 406215 [details] Patch

Chris Dumez

Comment 4 2020-08-07 14:53:53 PDT

Created attachment 406217 [details] Patch

Chris Dumez

Comment 5 2020-08-07 15:37:21 PDT

Created attachment 406220 [details] Patch

Chris Dumez

Comment 6 2020-08-07 16:36:34 PDT

Created attachment 406225 [details] Patch