Bug 215262

Summary: [GStreamer] gst-full standalone library support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, berto, calvaris, cgarcia, clopez, eric.carlson, ews-watchlist, glenn, gustavo, gyuyoung.kim, jer.noble, menard, philipj, ryuan.choi, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch calvaris: review+, calvaris: commit-queue-

Philippe Normand
Reported 2020-08-07 02:11:31 PDT
In some deployment cases it might be convenient to rely on the gst-full library which bundles the GStreamer libraries and plugins in a single shared library.
Attachments
Patch (32.95 KB, patch)
2020-08-07 04:54 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (32.94 KB, patch)
2020-08-07 04:56 PDT, Philippe Normand 		calvaris: review+
calvaris: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-08-07 04:54:08 PDT
Created attachment 406162 [details] Patch
EWS Watchlist
Comment 2 2020-08-07 04:54:53 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Philippe Normand
Comment 3 2020-08-07 04:56:59 PDT
Created attachment 406163 [details] Patch
Xabier Rodríguez Calvar
Comment 4 2020-08-10 08:20:09 PDT
Comment on attachment 406163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406163&action=review > Source/WebKit/UIProcess/gstreamer/WebPageProxyGStreamer.cpp:45 > +#if !USE(GSTREAMER_FULL) > auto request = InstallMissingMediaPluginsPermissionRequest::create(*this, details, description); > if (pageClient().decidePolicyForInstallMissingMediaPluginsPermissionRequest(request.get())) > return; > > request->deny(); > +#endif #else UNUSED_PARAM... > Tools/ChangeLog:8 > + Disable GStreamer options command-line support in MiniBrowsers. This isn't very useful and State that this is a non-related clean-up or move it to a different patch, please.
Philippe Normand
Comment 5 2020-08-11 01:17:45 PDT
Committed r265492: <https://trac.webkit.org/changeset/265492>
Radar WebKit Bug Importer
Comment 6 2020-08-11 01:18:21 PDT
<rdar://problem/66824560>
Note You need to log in before you can comment on or make changes to this bug.