Bug 215207

Summary: Remove UIScriptController.removeAllDynamicDictionaries()
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, megan_gardner, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Take 2 none

Wenson Hsieh
Reported 2020-08-05 19:11:38 PDT
SSIA
Attachments
Patch (7.04 KB, patch)
2020-08-05 19:16 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Take 2 (7.78 KB, patch)
2020-08-06 17:12 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-08-05 19:16:42 PDT
Created attachment 406068 [details] Patch
Wenson Hsieh
Comment 2 2020-08-06 07:38:46 PDT
Comment on attachment 406068 [details] Patch Thanks for the review!
EWS
Comment 3 2020-08-06 07:46:40 PDT
Committed r265325: <https://trac.webkit.org/changeset/265325> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406068 [details].
Wenson Hsieh
Comment 4 2020-08-06 13:19:42 PDT
It looks like a handful of layout tests in fast/forms and editing/pasteboard are timing out after this change, due to hangs underneath UIKeyboardImpl :(
Wenson Hsieh
Comment 5 2020-08-06 13:21:12 PDT
Reverted r265325 for reason: Caused several tests in fast/forms and editing/pasteboard to time out Committed r265345: <https://trac.webkit.org/changeset/265345>
Wenson Hsieh
Comment 6 2020-08-06 17:12:37 PDT
Created attachment 406136 [details] Take 2
Wenson Hsieh
Comment 7 2020-08-07 08:52:03 PDT
Comment on attachment 406136 [details] Take 2 Thank you for the review!
EWS
Comment 8 2020-08-07 09:14:33 PDT
Committed r265376: <https://trac.webkit.org/changeset/265376> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406136 [details].
Note You need to log in before you can comment on or make changes to this bug.