Bug 215191 – Document versions of C++ and Python

• Component: New Bugs
• Status: RESOLVED FIXED

[Darin Adler]

Document versions of C++ and Python

[Darin Adler]

Created attachment 406037 [details]
Patch

[Darin Adler]

Very rough draft. Currently does not require that "webkit-patch" be compatible with Python 2. Does not clarify that all new scripts need to be compatible with Python 3. Does not include information about writing python3 on the shebang line to make sure we get it on Apple systems.

May be incorrect in other major ways. Looking for comment or refinements.

[Jonathan Bedard]

Comment on attachment 406037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406037&action=review

> Websites/webkit.org/languages.md:32
> +This includes scripts like `webkit-patch`.

webkit-patch is an example of something that needs to be Python 2 compatible, otherwise we can't apply patches on machines without Python 3.

`configure-xcode-for-embedded-development` and `lint-test-expectations` would be better examples

[Darin Adler]

Comment on attachment 406037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406037&action=review

>> Websites/webkit.org/languages.md:32
>> +This includes scripts like `webkit-patch`.
> 
> webkit-patch is an example of something that needs to be Python 2 compatible, otherwise we can't apply patches on machines without Python 3.
> 
> `configure-xcode-for-embedded-development` and `lint-test-expectations` would be better examples

So humans can do that, or so computers can do it?

If it’s for humans, can they install Python 3?

[Jonathan Bedard]

Comment on attachment 406037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406037&action=review

>>> Websites/webkit.org/languages.md:32
>>> +This includes scripts like `webkit-patch`.
>> 
>> webkit-patch is an example of something that needs to be Python 2 compatible, otherwise we can't apply patches on machines without Python 3.
>> 
>> `configure-xcode-for-embedded-development` and `lint-test-expectations` would be better examples
> 
> So humans can do that, or so computers can do it?
> 
> If it’s for humans, can they install Python 3?

I'm not aware of anywhere we have bots calling this script, since Aakash moved us to Buildbot for EWS.

If we're going to let ourselves break webkit-patch for Mojave, then we need to document installing Python 3 for Mojave. I would say that if we're officially documenting things, webkit-patch should either be in the 'needs to support Python 2' list or not mentioned, because this is the one script involved in developing WebKit that I've actually used on a machine without Python 3 in the last 6 months.

[Alexey Proskuryakov]

webkit-patch is a weird beast, as it doesn’t have anything required by engineers for WebKit development, but many engineers rely on it. Otherwise, svn-apply and svn-create-patch are sufficient.

[Maciej Stachowiak]

Comment on attachment 406037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406037&action=review

> Websites/webkit.org/languages.md:1
> +### C++

Does this file need to start with a level header, or will whatever pulls it into WordPress add that?

> Websites/webkit.org/languages.md:5
> +Itâs C++17.

Guessing that this is a curly single quote/apostrophe but the double quotes just above are straight quotes. Better to be consistent. (There's other apparent curly quotes lower in the file.

> Websites/webkit.org/languages.md:21
> +Scripts used for building and testing WebKit

Was this meant to be a level 4 header starting with ####? Seems strange as a paragraph instead of a section header.

> Websites/webkit.org/languages.md:30
> +Scripts used for developing WebKit

Likewise, should this be a section header?

[Fujii Hironori]

(In reply to Darin Adler from comment #4)
> If it’s for humans, can they install Python 3?

We had a discussion before.

https://lists.webkit.org/pipermail/webkit-dev/2019-July/030750.html

> Having to download and install anything else would be a significant additional step.
> 
> — Darin

[Fujii Hironori]

WebKit has another GCC version policy.

WebKitGTK/GCCRequirement – WebKit
https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement

[Radar WebKit Bug Importer]

<rdar://problem/66933118>

[Darin Adler]

Created attachment 406798 [details]
Patch

[Darin Adler]

Uploaded a new draft, responding to most of the comments above.

[Jonathan Bedard]

Comment on attachment 406798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406798&action=review

> Websites/webkit.org/languages.md:37
> +This includes scripts like  `configure-xcode-for-embedded-development` and  `lint-test-expectations`.

Nit: Double spaces after "like" and "and", seems like a typo

[Darin Adler]

Committed r265827: <https://trac.webkit.org/changeset/265827>

[Simon Fraser (smfr)]

Comment on attachment 406798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406798&action=review

> Websites/webkit.org/languages.md:30
> +environment for older Apple OS versions such as macOS Movaje.

"macOS Movaje"