Bug 215140

Summary:

Web Inspector: Clicking on sortable Table headers should expand vertical borders

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Video] macOS table header divider height	none
Patch (for prosperity)	nvasilyev: review-, nvasilyev: commit-queue-
Patch	none
[Video] With patch applied	none

Nikita Vasilyev

Reported 2020-08-04 14:45:47 PDT

Created attachment 405944 [details] [Video] macOS table header divider height On macOS Catalina and Big Sur, clicking on the header should expand the height of vertical dividers.

Attachments
[Video] macOS table header divider height (307.99 KB, video/quicktime) 2020-08-04 14:45 PDT, Nikita Vasilyev	no flags	Details
Patch (for prosperity) (4.63 KB, patch) 2020-08-10 19:43 PDT, Nikita Vasilyev	nvasilyev: review- nvasilyev: commit-queue-	Details Formatted Diff Diff
Patch (1.32 KB, patch) 2020-08-10 19:49 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Video] With patch applied (1.10 MB, video/quicktime) 2020-08-10 19:49 PDT, Nikita Vasilyev	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Nikita Vasilyev

Comment 1 2020-08-10 19:43:06 PDT

Created attachment 406353 [details] Patch (for prosperity) In this patch I attempted to resolve the issue in both Table and DataGrid. I didn't fix it in DataGrid completely (there's an edge case with hidden columns). I'm going to abandon this because DataGrid is being phased out in favor of Table.

Nikita Vasilyev

Comment 2 2020-08-10 19:49:09 PDT

Created attachment 406354 [details] Patch

Nikita Vasilyev

Comment 3 2020-08-10 19:49:44 PDT

Created attachment 406355 [details] [Video] With patch applied

Devin Rousso

Comment 4 2020-08-11 11:09:55 PDT

Comment on attachment 406354 [details] Patch r=me, nice fix :)

EWS

Comment 5 2020-08-11 11:12:35 PDT

Committed r265507: <https://trac.webkit.org/changeset/265507> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406354 [details].

Radar WebKit Bug Importer

Comment 6 2020-08-11 11:13:18 PDT

<rdar://problem/66850270>

Note You need to log in before you can comment on or make changes to this bug.