Bug 21510

Summary: REGRESSION: Patterns are recreated every time they paint
Product: WebKit Reporter: Eric Seidel <eric@webkit.org>
Component: HTML DOMAssignee: Nobody <webkit-unassigned@lists.webkit.org>
Status: RESOLVED FIXED    
Severity: Normal CC: pdr@google.com
Priority: P1 Keywords: NeedsRadar, NeedsReduction, Regression
Version: 528+ (Nightly build)   
Hardware: Macintosh   
OS: Mac OS X 10.5   
Bug Depends on:    
Bug Blocks: 21498    

Description From 2008-10-09 15:07:23 PST
Patterns are recreated every time they paint

This is is a possible perf regression from the previous behavior where patterns were cached based on CTM over in the Canvas2dGraphicsContext object.  Now that they're over on GraphicsContext we don't have a similar system for caching (yet).  This bug is about building one so that we aren't recreating patterns every time we draw them.
------- Comment #1 From 2008-10-09 15:10:35 PST -------
Btw, one way to solve this would be to simply roll out r35966, but given that we've had no complaints of poor canvas pattern drawing performance, and no performance tests to validate that we've actually regressed, I recommend we leave this code in for now.
------- Comment #2 From 2008-10-09 19:30:10 PST -------
all functional regressions from r35966  (tracked by bug 21498) are now fixed.  Only this possible perf regression remains.
------- Comment #3 From 2008-10-09 19:32:14 PST -------
The way to typically observe pattern performance issues is with large JPEGs as the pattern tile.  This is how we noticed perf issues with creation/throwing stuff away in background tiling patterns in HTML.
------- Comment #4 From 2008-10-09 19:33:41 PST -------
Initial landing in r37462.
------- Comment #5 From 2008-10-09 19:33:55 PST -------
Wrong bug. Sorry.
------- Comment #6 From 2012-12-30 17:06:01 PST -------
I suspect this has long since been solved.