Bug 215049 – Update generate-message-receiver.py to account for intermittent corruption

• Component: Tools / Tests
• Status: CLOSED CONFIGURATION CHANGED

[Keith Rollin]

Several developers have reported build failures due to the output of generate-message-receiver.py including a 4K chunk of NULs at the start of the generated files. It's not apparent if this is a script issue, a Python issue, an OS issue, a hardware issue, or what. But in order to make this less of an issue, update generate-message-receiver.py as follows:

- When files are written, check for the corruption. If it occurs, retry up to five times. Write a message to stderr if corruption occurs in order to help corral the issue. After five times, give up.
- Add support for the WK_SKIP_RETRY_ON_CORRUPTION environment variable. If set to non-zero/empty, then give up without retrying. By not retrying, the adventurous developer may be able to examine the conditions that led to the corruption and figure out what happened.

[Radar WebKit Bug Importer]

<rdar://problem/66412328>

[Keith Rollin]

See also radar 63595589

[Keith Rollin]

Created attachment 405767 [details]
Patch

[Keith Rollin]

Comment on attachment 405767 [details]
Patch

I tested the script in isolation, but not in an actual `make`.

[Darin Adler]

Maybe we should hold off on this a while and see if the fix to bug 215054 takes care of the problem?

[Keith Rollin]

Yeah, there's no need for this patch any more.

[Keith Rollin]

At least, as you say, as long as bug 215054 and bug 215064 work.