Bug 215043

Summary:

[Mac] Add Experimental Feature preference for SW VP9

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, bdakin, commit-queue, darin, eric.carlson, peng.liu6, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

215060

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch for landing	none
Patch for landing	none
Follow up patch	none

Jer Noble

Reported 2020-07-31 16:46:24 PDT

[Mac] Add Experimental Feature preference for SW VP9

Attachments
Patch (8.72 KB, patch) 2020-07-31 17:09 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (8.72 KB, patch) 2020-07-31 17:11 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (8.57 KB, patch) 2020-07-31 17:18 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (8.89 KB, patch) 2020-08-06 11:30 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (8.96 KB, patch) 2020-08-11 15:35 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Follow up patch (1.64 KB, patch) 2020-08-17 10:04 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2020-07-31 16:47:39 PDT

<rdar://problem/66400034>

Jer Noble

Comment 2 2020-07-31 17:09:23 PDT

Created attachment 405759 [details] Patch

Jer Noble

Comment 3 2020-07-31 17:11:19 PDT

Created attachment 405760 [details] Patch

Jer Noble

Comment 4 2020-07-31 17:18:40 PDT

Created attachment 405761 [details] Patch

EWS

Comment 5 2020-07-31 18:30:02 PDT

Committed r265171: <https://trac.webkit.org/changeset/265171> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405761 [details].

Aakash Jain

Comment 6 2020-08-01 06:38:09 PDT

(In reply to EWS from comment #5) > Committed r265171: <https://trac.webkit.org/changeset/265171> This broke two api-mac tests as also warned by EWS. - TestWebKitAPI.InAppBrowserPrivacy.AppBoundDomainAllowsServiceWorkers - TestWebKitAPI.WebKit.RelaxThirdPartyCookieBlocking History: https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebKit.RelaxThirdPartyCookieBlocking&test=TestWebKitAPI.InAppBrowserPrivacy.AppBoundDomainAllowsServiceWorkers

WebKit Commit Bot

Comment 7 2020-08-01 06:39:00 PDT

Re-opened since this is blocked by bug 215060

Jer Noble

Comment 8 2020-08-06 11:20:27 PDT

Those t(In reply to Aakash Jain from comment #6) > (In reply to EWS from comment #5) > > Committed r265171: <https://trac.webkit.org/changeset/265171> > > This broke two api-mac tests as also warned by EWS. > > - TestWebKitAPI.InAppBrowserPrivacy.AppBoundDomainAllowsServiceWorkers > - TestWebKitAPI.WebKit.RelaxThirdPartyCookieBlocking Objection. Those tests failed on EWS without this patch applied. 18 run-api-tests-without-patch 0 s Found 1 new API test failure: TestWebKitAPI.WebKit.RelaxThirdPartyCookieBlocking (failure)19 analyze-api-tests-results stderr view all 6 lines download Failures in API Test first run: set([u'TestWebKitAPI.WebKit.RelaxThirdPartyCookieBlocking']) Failures in API Test second run: set([u'TestWebKitAPI.WebKit.RelaxThirdPartyCookieBlocking']) Flaky Tests: set([]) Failures in API Test on clean tree: set([]) New failures: set([u'TestWebKitAPI.WebKit.RelaxThirdPartyCookieBlocking']) > History: > https://results.webkit.org/?suite=api-tests&suite=api- > tests&test=TestWebKitAPI.WebKit. > RelaxThirdPartyCookieBlocking&test=TestWebKitAPI.InAppBrowserPrivacy. > AppBoundDomainAllowsServiceWorkers

Jer Noble

Comment 9 2020-08-06 11:24:40 PDT

Ah, I misunderstood the output here.

Jer Noble

Comment 10 2020-08-06 11:30:07 PDT

Created attachment 406095 [details] Patch for landing

EWS

Comment 11 2020-08-08 13:14:24 PDT

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

Jer Noble

Comment 12 2020-08-11 15:35:07 PDT

Created attachment 406426 [details] Patch for landing

EWS

Comment 13 2020-08-11 16:07:56 PDT

Committed r265533: <https://trac.webkit.org/changeset/265533> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406426 [details].

Jer Noble

Comment 14 2020-08-17 10:04:11 PDT

Reopening to attach new patch.

Jer Noble

Comment 15 2020-08-17 10:04:12 PDT

Created attachment 406723 [details] Follow up patch

EWS

Comment 16 2020-08-17 10:51:55 PDT

Committed r265761: <https://trac.webkit.org/changeset/265761> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406723 [details].

Note You need to log in before you can comment on or make changes to this bug.