Bug 215040

Summary: Added Constructor to AnalyserNode
Product: WebKit Reporter: Clark Wang <clark_wang>
Component: Web AudioAssignee: Clark Wang <clark_wang>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch none

Description Clark Wang 2020-07-31 15:54:17 PDT 
Added constructor: https://www.w3.org/TR/webaudio/#AnalyserNode-constructors. Also added in AnalyserOptions.
Comment 1 Clark Wang 2020-07-31 16:02:12 PDT 
Created attachment 405754 [details]
Patch
Comment 2 Chris Dumez 2020-07-31 16:07:47 PDT 
roses are red, so are your EWS bubbles.
Comment 3 Chris Dumez 2020-07-31 16:12:48 PDT 
Comment on attachment 405754 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405754&action=review

> Source/WebCore/Modules/webaudio/AnalyserNode.cpp:124
> +    if (maxDecibels() && k >= maxDecibels())

0 dB seems like a valid value for decibels so why is it OK to bypass the security check for 0?
Comment 4 Clark Wang 2020-07-31 17:27:16 PDT 
Created attachment 405762 [details]
Patch
Comment 5 Clark Wang 2020-07-31 17:28:04 PDT 
(In reply to Chris Dumez from comment #2)
> roses are red, so are your EWS bubbles.

beautiful, thank you
Comment 6 Chris Dumez 2020-08-03 08:38:13 PDT 
Comment on attachment 405762 [details]
Patch

r=me
Comment 7 EWS 2020-08-03 08:51:46 PDT 
Committed r265196: <https://trac.webkit.org/changeset/265196>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405762 [details].
Comment 8 Radar WebKit Bug Importer 2020-08-03 13:36:07 PDT 
<rdar://problem/66489212>