Bug 215040

Summary: Added Constructor to AnalyserNode
Product: WebKit Reporter: Clark Wang <clark_wang>
Component: Web AudioAssignee: Clark Wang <clark_wang>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch none

Clark Wang
Reported 2020-07-31 15:54:17 PDT
Added constructor: https://www.w3.org/TR/webaudio/#AnalyserNode-constructors. Also added in AnalyserOptions.
Attachments
Patch (57.25 KB, patch)
2020-07-31 16:02 PDT, Clark Wang 		no flags
DetailsFormatted DiffDiff
Patch (56.93 KB, patch)
2020-07-31 17:27 PDT, Clark Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Clark Wang
Comment 1 2020-07-31 16:02:12 PDT
Created attachment 405754 [details] Patch
Chris Dumez
Comment 2 2020-07-31 16:07:47 PDT
roses are red, so are your EWS bubbles.
Chris Dumez
Comment 3 2020-07-31 16:12:48 PDT
Comment on attachment 405754 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405754&action=review > Source/WebCore/Modules/webaudio/AnalyserNode.cpp:124 > + if (maxDecibels() && k >= maxDecibels()) 0 dB seems like a valid value for decibels so why is it OK to bypass the security check for 0?
Clark Wang
Comment 4 2020-07-31 17:27:16 PDT
Created attachment 405762 [details] Patch
Clark Wang
Comment 5 2020-07-31 17:28:04 PDT
(In reply to Chris Dumez from comment #2) > roses are red, so are your EWS bubbles. beautiful, thank you
Chris Dumez
Comment 6 2020-08-03 08:38:13 PDT
Comment on attachment 405762 [details] Patch r=me
EWS
Comment 7 2020-08-03 08:51:46 PDT
Committed r265196: <https://trac.webkit.org/changeset/265196> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405762 [details].
Radar WebKit Bug Importer
Comment 8 2020-08-03 13:36:07 PDT
<rdar://problem/66489212>
Note You need to log in before you can comment on or make changes to this bug.