Bug 215024

Summary:

Re-enable NO_SMT on Catalina

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	ap: review+
patch for landing	none

Description Saam Barati 2020-07-31 11:10:35 PDT

...

Comment 1 Saam Barati 2020-07-31 11:26:39 PDT

Created attachment 405713 [details]
patch

Comment 2 Alexey Proskuryakov 2020-07-31 11:32:14 PDT

Comment on attachment 405713 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405713&action=review

> Source/JavaScriptCore/runtime/Options.cpp:235
> +#if CPU(X86_64) && (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 110000)

I’m not sure what this does in macCatalyst case, or what we want it to do.

Comment 3 Saam Barati 2020-07-31 11:40:08 PDT

Created attachment 405716 [details]
patch for landing

Comment 4 EWS 2020-07-31 12:24:14 PDT

Committed r265154: <https://trac.webkit.org/changeset/265154>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405716 [details].

Comment 5 Radar WebKit Bug Importer 2020-07-31 12:25:22 PDT

<rdar://problem/66393176>