Bug 215024

Summary: Re-enable NO_SMT on Catalina
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ap: review+
patch for landing none

Saam Barati
Reported 2020-07-31 11:10:35 PDT
...
Attachments
patch (2.22 KB, patch)
2020-07-31 11:26 PDT, Saam Barati 		ap: review+
DetailsFormatted DiffDiff
patch for landing (2.30 KB, patch)
2020-07-31 11:40 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-07-31 11:26:39 PDT
Created attachment 405713 [details] patch
Alexey Proskuryakov
Comment 2 2020-07-31 11:32:14 PDT
Comment on attachment 405713 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=405713&action=review > Source/JavaScriptCore/runtime/Options.cpp:235 > +#if CPU(X86_64) && (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 110000) I’m not sure what this does in macCatalyst case, or what we want it to do.
Saam Barati
Comment 3 2020-07-31 11:40:08 PDT
Created attachment 405716 [details] patch for landing
EWS
Comment 4 2020-07-31 12:24:14 PDT
Committed r265154: <https://trac.webkit.org/changeset/265154> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405716 [details].
Radar WebKit Bug Importer
Comment 5 2020-07-31 12:25:22 PDT
<rdar://problem/66393176>
Note You need to log in before you can comment on or make changes to this bug.