Summary: | Remove Range::create and many more uses of live ranges | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||
Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cdumez, cfleizach, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jcraig, jdiggs, jer.noble, kangil.han, mifenton, philipj, samuel_white, sam, sergio, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Darin Adler
2020-07-30 20:09:57 PDT
Created attachment 405654 [details]
Patch
The follow up to this is search and destroy of calls to createLiveRange. Should be done in chunks in case we break something. Created attachment 405660 [details]
Patch
Created attachment 405665 [details]
Patch
Created attachment 405709 [details]
Patch
Last version passed EWS all green, but didn’t have change log yet. Now up with change log and ready to review. Comment on attachment 405709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405709&action=review > Source/WebCore/dom/DocumentMarkerController.h:118 > +WEBCORE_EXPORT SimpleRange range(Node&, const DocumentMarker&); I am not sure how I feel about this just being called "range", though I can see the arguments against making this an overload of makeSimpleRange as well. > Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm:479 > + auto firstVP = [first _visiblePosition]; > + auto secondVP = [second _visiblePosition]; Not new, but also don't think the abbreviations are great here. Committed r265176: <https://trac.webkit.org/changeset/265176> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405709 [details]. Comment on attachment 405709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405709&action=review >> Source/WebCore/dom/DocumentMarkerController.h:118 >> +WEBCORE_EXPORT SimpleRange range(Node&, const DocumentMarker&); > > I am not sure how I feel about this just being called "range", though I can see the arguments against making this an overload of makeSimpleRange as well. I will rename to makeSimpleRange for now. >> Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm:479 >> + auto secondVP = [second _visiblePosition]; > > Not new, but also don't think the abbreviations are great here. I agree and almost changed them. Probably should have gone with firstPosition and secondPosition. Comment on attachment 405709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405709&action=review >> Source/WebCore/dom/DocumentMarkerController.h:118 >> +WEBCORE_EXPORT SimpleRange range(Node&, const DocumentMarker&); > > I am not sure how I feel about this just being called "range", though I can see the arguments against making this an overload of makeSimpleRange as well. I will rename to makeSimpleRange for now. >> Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm:479 >> + auto secondVP = [second _visiblePosition]; > > Not new, but also don't think the abbreviations are great here. I agree and almost changed them. Probably should have gone with firstPosition and secondPosition. |