Summary: | Add OfflineAudioCompletionEvent constructor | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, annulen, clark_wang, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
URL: | https://www.w3.org/TR/webaudio/#OfflineAudioCompletionEvent | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 212611 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2020-07-30 15:59:51 PDT
Created attachment 405634 [details]
Patch
Comment on attachment 405634 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405634&action=review > Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.cpp:57 > + , m_renderedBuffer(WTFMove(init.renderedBuffer)) This is a pre-existing issue but it seems that m_renderedBuffer should be a Ref<> since it cannot be null. Looking at the other OfflineAudioCompletionEvent::create, it seems it should be OfflineAudioCompletionEvent::create(Ref<AudioBuffer>&&) as well. > Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.h:29 > +#include "OfflineAudioCompletionEventInit.h" Can we forward declare OfflineAudioCompletionEventInit instead? > Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.h:30 > #include <wtf/RefPtr.h> Might not be needed? > Source/WebCore/Modules/webaudio/OfflineAudioCompletionEventInit.h:33 > + RefPtr<AudioBuffer> renderedBuffer; Would be nice if we could make it a Ref<>. I guess this is a binding generator limitation? Maybe we can actually do it now that Ref is copyable. > LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt:163 > +PASS OfflineAudioCompletionEvent interface object length Do we have enough test coverage? Can we make sure we have tests creating OfflineAudioCompletionEvent from JS? Comment on attachment 405634 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405634&action=review >> Source/WebCore/Modules/webaudio/OfflineAudioCompletionEventInit.h:33 >> + RefPtr<AudioBuffer> renderedBuffer; > > Would be nice if we could make it a Ref<>. I guess this is a binding generator limitation? > Maybe we can actually do it now that Ref is copyable. This is a bindings generator limitation, sadly. Created attachment 405706 [details]
Patch
Tools/Scripts/svn-apply failed to apply attachment 405706 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 405752 [details]
Patch
Committed r265168: <https://trac.webkit.org/changeset/265168> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405752 [details]. |